Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (media/child) form improvements 2 #908

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Nov 7, 2022

Replaces #890

GitHub Issue: Slack conversation with C.Z.:

"How can I add my own media types to add media? If I add them, they will not show up under add media"

What does this Pull Request do?

Tells you, when on the "add Media" and "add Members" page, that the bundles below are available because they have the magic field configured to this bundle.

What's new?

Help text on the Add Children (/node/{node}/members/add) and Add Media (/node/{node}/media/add) pages.

How should this be tested?

  • does the text show up?
  • do you have suggestions to make it better?

Note: I tried to get "this bundle" (the bundle of the current node) to show up as the bundle's human readable name, but without loading a bunch of extra classes I could only get it to show the machine name of the bundle. So I didn't. If you think it's worth it, please send code.

Documentation Status

  • Does this change existing behaviour that's currently documented? no.
  • Does this change require new pages or sections of documentation? no but new screenshots might be nice.
  • Who does this need to be documented for? it is documentation.
  • Associated documentation pull request(s): ___ or documentation issue ___ see above.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@rosiel
Copy link
Member Author

rosiel commented Nov 7, 2022

@whikloj thanks for your comment on #890. I agree. I tried to improve the wording somewhat.

Screen Shot 2022-11-07 at 6 46 29 PM

Sorry for the mess up of the previous PR.

  • I hope the <code> tag renders okay in different admin themes.
  • I realized that being "configured to allow this content type" has no effect on whether the media/content type shows up in this list, so I removed it.
  • The "Manage media types" link only shows up if you have permission to get to the route. 😄

@rosiel rosiel changed the title Add form improvements 2 Add (media/child) form improvements 2 Nov 8, 2022
@nigelgbanks nigelgbanks self-requested a review December 14, 2022 09:40
Copy link
Member

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested, presents the links with descriptions as described.

@nigelgbanks nigelgbanks merged commit f780c69 into Islandora:2.x Dec 14, 2022
@rosiel rosiel deleted the add-form-improvements-2 branch December 14, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants