Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxonomy manager as required module for OOTB experience. #56

Closed
wants to merge 1 commit into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 4, 2021

GitHub Issue: Islandora-Devops/islandora-starter-site#37

What does this Pull Request do?

Adds a new module to be installed with Defaults. This enables some desired features for taxonomy management (though is sadly lacking, it's better than nothing).

What's new?

Require taxonomy_manager.

  • Does this change require documentation to be updated? Yes - incoming PR.
  • Does this change add any new dependencies? Yes - taxonomy manager.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

Install via the Playbook or Isle, and you should get a Drupal with Taxonomy manager installed.

Additional Notes:

This seems odd here but there currently isn't a single place to add this so that Ansible and ISLE will both load it.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

@rosiel rosiel changed the base branch from 8.x-1.x to 2.x October 5, 2021 21:29
@seth-shaw-unlv seth-shaw-unlv requested a review from mjordan October 6, 2021 17:50
@mjordan
Copy link
Contributor

mjordan commented Oct 7, 2021

Tested on an existing Playbook by running composer require drupal/taxonomy_manager ^2.0, then drush en -y taxonomy_manager. After playing around with it, Drupal log is clean.

Copy link
Contributor

@mjordan mjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an existing Playbook by running composer require drupal/taxonomy_manager ^2.0, then drush en -y taxonomy_manager. After playing around with it, Drupal log is clean.

@@ -16,6 +16,7 @@
"islandora/controlled_access_terms" : "dev-8.x-1.x",
"drupal/field_group" : "^3.0",
"drupal/field_permissions" : "^1.0",
"drupal/pdf": "^1.1"
"drupal/pdf": "^1.1",
"drupal/taxonomy_manager": "^2.0"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an existing Playbook by running composer require drupal/taxonomy_manager ^2.0, then drush en -y taxonomy_manager. After playing around with it, Drupal log is clean.

@rosiel
Copy link
Member Author

rosiel commented Oct 14, 2021

Sounds like as good a test as any.

@elizoller
Copy link
Member

since @mjordan, can this be merged?

@rosiel rosiel closed this Dec 1, 2022
@rosiel rosiel deleted the islandora-1900 branch December 1, 2022 00:06
@rosiel
Copy link
Member Author

rosiel commented Dec 1, 2022

defaults is being deprecated, we can add it to the starter site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants