Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access_terms #64

Merged
merged 12 commits into from
Mar 23, 2022
Merged

Remove access_terms #64

merged 12 commits into from
Mar 23, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Feb 3, 2022

Slack discussion: https://islandora.slack.com/archives/C019U12D44Q/p1643905893529709

What does this Pull Request do?

Solves the unmet dependencies preventing mirador from being installed.

What's new?

  • removed references to a field (that was "hidden" anyway)

How should this be tested?

Currently when trying to install islandora defaults, it doesn't let you install Islandora_mirador.
however with this, it can be installed

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@ajstanley

Copy link
Contributor

@ajstanley ajstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - work perfectly.

@rosiel
Copy link
Member Author

rosiel commented Feb 16, 2022

@ajstanley the build is green now... :)

@whikloj whikloj self-requested a review February 23, 2022 18:16
@rosiel
Copy link
Member Author

rosiel commented Mar 17, 2022

@whikloj do you still want to review this? I can push the branch to islandora if that helps (according to what I know which is documented here, its' very difficult to test an islandora defaults that's not a branch of the main repo)

@rosiel
Copy link
Member Author

rosiel commented Mar 23, 2022

@whikloj in case it helps make testing easier, i've pushed this to a branch on Islandora: https://github.com/Islandora/islandora_defaults/tree/mirador-2

@whikloj
Copy link
Member

whikloj commented Mar 23, 2022

Sorry @rosiel, I'm spinning up a new islandora-playbook now.

@ajstanley ajstanley merged commit db7a508 into Islandora:2.x Mar 23, 2022
@rosiel rosiel deleted the mirador-2 branch March 23, 2022 17:59
@rosiel rosiel restored the mirador-2 branch March 23, 2022 17:59
@rosiel rosiel deleted the mirador-2 branch March 23, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants