New sniffs

[whikloj]

JIRA Ticket: No JIRA, work related to Islandora/islandora#714

This will also test the use case for Islandora/islandora#716

What does this Pull Request do?

Updates code for new code sniffs

How should this be tested?

Travis is green and then check that testing is complete.

Additional Notes:

Example:

• Does this change the interface, add a new feature, or otherwise change behaviours that would require updating documentation? no
• Does this change add any new dependencies? no
• Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
• Could this change impact execution of existing code? no

Interested parties

@Islandora/7-x-1-x-committers

[jonathangreen]

for a cleaner look maybe could do this:

env:
  global:
    - CODESNIFFER_IGNORE="vendor,*.info,*.txt,*.md,SolrPhpClient"
  matrix:
    - FEDORA_VERSION="3.5"
    - FEDORA_VERSION="3.6.2"
    - FEDORA_VERSION="3.7.0"
    - FEDORA_VERSION="3.8.1"

[whikloj]

I can make that change but as coder is failing on the embedded Apache Solr Client I'll need to figure that out first and I have no idea how to get it to stop.

[bondjimbond]

@whikloj I'm coming here from Islandora/islandora#722 ... so am I to understand that the failures we're seeing here are because the affected files are supposed to be ignored, but are not getting skipped? And that's due to the "style" check?

And, furthermore, the "style" check is redundant because we run phpcs anyway?

[whikloj]

Annnnnnd coder still checks the embedded SolrPhpClient. The only solution I now see is pulling the SolrPhpClient out of islandora_solr_search and keeping it separate, but I don't think I have the interest in doing that right now.

[DiegoPino]

Any change we can exclude that whole folder @whikloj ? Like https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-files-and-folders

[whikloj]

I couldn't find one, but that doesn't mean there isn't one.

[DiegoPino]

@whikloj it seems like the syntax is wrong
So this is how that thing
CODESNIFFER_IGNORE="vendor,*.info,*.txt,*.md,SolrPhpClient" is passed to travis here:

https://github.com/Islandora/islandora/blob/7.x/tests/scripts/travis_scripts.sh#L42

And my guts tell me it should be

CODESNIFFER_IGNORE="vendor,*.info,*.txt,*.md,/SolrPhpClient" ?

[whikloj]

@DiegoPino That is for PHPCS and while there are issues appearing currently for PHPCS here the one that checks ApacheSolrClient is drush coder here and it fails here

[DiegoPino]

Gosh. True. My fault. El El mar, 16 de jul. de 2019 a las 16:57, Jared Whiklo < notifications@github.com> escribió:

@DiegoPino <https://github.com/DiegoPino> That is for PHPCS and while there are issues appearing currently for PHPCS here <https://travis-ci.org/Islandora/islandora_solr_search/jobs/542274814#L978> the one that checks ApacheSolrClient is drush coder here <https://github.com/Islandora/islandora/blob/7.x/tests/scripts/travis_scripts.sh#L25> and it fails here <https://travis-ci.org/Islandora/islandora_solr_search/jobs/542274814#L832> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#359?email_source=notifications&email_token=ABU7ZZ6WQ2KV6KRY23QB5UDP7YY4PA5CNFSM4GZLLQCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2CEBMI#issuecomment-511983793>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABU7ZZ6D3PU4MFOZRVTNUBLP7YY4PANCNFSM4GZLLQCA> .

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

[DiegoPino]

So Jared. Why do we need drush coder if we run phpcs? Seems like drush coder does phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,js,css,info,txt,md /path/to/module Maybe i’m wrong... El El mar, 16 de jul. de 2019 a las 17:35, Diego Pino <dpino@metro.org> escribió:

Gosh. True. My fault. El El mar, 16 de jul. de 2019 a las 16:57, Jared Whiklo < ***@***.***> escribió: > @DiegoPino <https://github.com/DiegoPino> That is for PHPCS and while > there are issues appearing currently for PHPCS here > <https://travis-ci.org/Islandora/islandora_solr_search/jobs/542274814#L978> > the one that checks ApacheSolrClient is drush coder here > <https://github.com/Islandora/islandora/blob/7.x/tests/scripts/travis_scripts.sh#L25> > and it fails here > <https://travis-ci.org/Islandora/islandora_solr_search/jobs/542274814#L832> > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#359?email_source=notifications&email_token=ABU7ZZ6WQ2KV6KRY23QB5UDP7YY4PA5CNFSM4GZLLQCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2CEBMI#issuecomment-511983793>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABU7ZZ6D3PU4MFOZRVTNUBLP7YY4PANCNFSM4GZLLQCA> > . > -- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)