Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test with php 8.1. #45

Merged
merged 2 commits into from
Jul 27, 2022
Merged

[CI] Test with php 8.1. #45

merged 2 commits into from
Jul 27, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jul 21, 2022

GitHub Issue: none (CI)

Tests are sneakily failing (they're green but are actually broken, failing on Drupal 10.). Recent Example.

What does this Pull Request do?

Updates the test matrix by

  • removing php 7.3
  • adding php 8.0, 8.1
  • including drupal pre-release 9.5.x-dev
  • removing drupal 10 till we can expect it to pass. (at least make it installable on D10!) Failing while showing the test as green gives a false expectation that it works on Drupal 10.
  • making all tests mandatory

Since we're no longer testing on it, officially deprecate Drupal 8.

How should this be tested?

  • Do tests pass?

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@Islandora/committers

@rosiel rosiel changed the title Test with php 8.1. [CI] Test with php 8.1. Jul 27, 2022
@rosiel rosiel requested a review from seth-shaw-asu July 27, 2022 18:03
@seth-shaw-asu seth-shaw-asu merged commit 2af105b into Islandora:2.x Jul 27, 2022
@rosiel rosiel deleted the 2.x branch March 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants