Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional output settings #95

Merged

Conversation

patrickmollohan
Copy link
Contributor

@patrickmollohan patrickmollohan commented Dec 12, 2023

This PR adds a checkbox in the export settings that toggles if a line should output anything after the %code% column on special lines and whether to print labels on their own lines.

Currently, special lines add unnecessary characters such as empty spaces for %pc%, %bytes%, %ia%, as well as any literals included in the output format, resulting in generated code that looks like:

                       lorom                                ; [      |        |      ]  
                                                            ; [      |        |      ]  
                                                            ; [      |        |      ]  
                       ORG $808000                          ; [      |        |      ]  
                                                            ; [      |        |      ]  
                                                            ; [      |        |      ]  
      Emulation_RESET: SEI                                  ; [808000|78      |      ] Sample emulation reset location
                       LDA.B #$01                           ; [808001|A901    |      ]  
                       STA.W $420D                          ; [808003|8D0D42  |00420D] this sets FastROM
                       JML.L FastRESET                      ; [808006|5C0A8080|80800A]  

When the added checkbox is unchecked, the generated code does not include anything after the %code% column, resulting in cleaner looking code:

                       lorom                                
                                                            
                                                            
                       ORG $808000                          
                                                            
                                                            
      Emulation_RESET: SEI                                  ; [808000|78      |      ] Sample emulation reset location
                       LDA.B #$01                           ; [808001|A901    |      ]  
                       STA.W $420D                          ; [808003|8D0D42  |00420D] this sets FastROM
                       JML.L FastRESET                      ; [808006|5C0A8080|80800A]  

Additionally, this PR allows you to output labels on their own lines:

    lorom
 
 
    ORG $808000
 
 
Emulation_RESET:
    SEI                                  ; [808000|78      |      ] Sample emulation reset location
    LDA.B #$01                           ; [808001|A901    |      ]
    STA.W $420D                          ; [808003|8D0D42  |00420D] this sets FastROM
    JML.L FastRESET                      ; [808006|5C0A8080|80800A]

This PR requires PR #2 of Diz.LogWriter.

This PR fixes issue #93.

@patrickmollohan patrickmollohan changed the title Add option to "Generate full line on special lines" Add additional output settings Dec 13, 2023
@binary1230 binary1230 merged commit 4300f2b into IsoFrieze:master Dec 14, 2023
1 check passed
@binary1230
Copy link
Collaborator

thanks \m/ 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants