Skip to content

Commit

Permalink
Offline maps ios 1345 (#1346)
Browse files Browse the repository at this point in the history
* Fixes #1345

* Temporary disable matrix builds

* #1345 - Add error to log.

* #1345 - Use the right branch

* #1345 - add back other platforms
  • Loading branch information
HarelM authored Oct 26, 2020
1 parent 2db6ce5 commit 299863b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions IsraelHiking.Web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion IsraelHiking.Web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"cordova-plugin-device": "^2.0.3",
"cordova-plugin-email-composer": "^0.9.2",
"cordova-plugin-file": "^6.0.1",
"cordova-plugin-file-transfer": "git+https://github.com/apache/cordova-plugin-file-transfer.git",
"cordova-plugin-file-transfer": "git+https://github.com/christiaan/cordova-plugin-file-transfer.git#master_fix-ios-headers",
"cordova-plugin-inappbrowser": "^4.0.0",
"cordova-plugin-ionic-webview": "5.0.0",
"cordova-plugin-media": "^5.0.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { MatDialogRef, MatDialog, MAT_DIALOG_DATA } from "@angular/material";

import { BaseMapComponent } from "../base-map.component";
import { ResourcesService } from "../../services/resources.service";
import { LoggingService } from '../../services/logging.service';

export type ProgressCallback = (value: number, text?: string) => void;

Expand All @@ -26,6 +27,7 @@ export class ProgressDialogComponent extends BaseMapComponent {

constructor(resources: ResourcesService,
private readonly matDialogRef: MatDialogRef<ProgressDialogComponent>,
private readonly loggingService: LoggingService,
@Inject(MAT_DIALOG_DATA) data: IProgressDialogConfig
) {
super(resources);
Expand All @@ -39,6 +41,7 @@ export class ProgressDialogComponent extends BaseMapComponent {
}).then(
() => this.matDialogRef.close(),
(ex) => {
this.loggingService.error("Error in download dialog, " + JSON.stringify(ex));
this.text = ex.message;
this.isError = true;
});
Expand Down

0 comments on commit 299863b

Please sign in to comment.