Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerhub DOCKER_TAG is empty #1524

Closed
HarelM opened this issue May 27, 2021 · 2 comments
Closed

Dockerhub DOCKER_TAG is empty #1524

HarelM opened this issue May 27, 2021 · 2 comments
Assignees
Labels
enhancement High Needed but there's a work around

Comments

@HarelM
Copy link
Member

HarelM commented May 27, 2021

Infra

It seems that when building in dockerhub the DOCKER_TAG is empty for both latest and a specific tag.
The issue is described here:
https://stackoverflow.com/questions/55347752/dockerhub-autobuild-for-a-github-pull-request-using-the-docker-tag-variable
There's a workaround described there, but I would like to avoid using it...
Also this issue:
docker/hub-feedback#508

@HarelM HarelM self-assigned this May 31, 2021
@HarelM HarelM added enhancement High Needed but there's a work around labels May 31, 2021
@HarelM HarelM added this to the Next Release milestone May 31, 2021
@HarelM
Copy link
Member Author

HarelM commented May 31, 2021

There are two options here:

  1. Use the dockerhub hook
  2. USe appveyor to build and publish docker images.

I'm not sure which I prefer, both are kinda hacks.
Since I can't remove the appveyor site build since I need to run the tests, it's probably better to use it instead of all the hacks in dockerhub.
I.e. disable the dockerhub automatic build and build and publish from appveyor

@HarelM
Copy link
Member Author

HarelM commented Jun 4, 2021

This seems to be working as expected in appveyor instead of docker hub, Also latest images will also have their version inside the dlls so opening swagger will show the relevant build.

@HarelM HarelM closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement High Needed but there's a work around
Projects
None yet
Development

No branches or pull requests

1 participant