Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any update on Leads & Subscription Endpoint? #86

Closed
1 of 2 tasks
manshu opened this issue Jul 19, 2020 · 17 comments
Closed
1 of 2 tasks

Any update on Leads & Subscription Endpoint? #86

manshu opened this issue Jul 19, 2020 · 17 comments

Comments

@manshu
Copy link

manshu commented Jul 19, 2020

I was checking the API and found no resource for both the endpoints. Any plan on that yet?

  • Leads endpoint
  • Subscription endpoint
@IsraelOrtuno
Copy link
Owner

Probably new endpoints, could you share the links?

@manshu
Copy link
Author

manshu commented Jul 19, 2020

https://developers.pipedrive.com/docs/api/v1/#!/Leads

That's for leads. I can't seem to find Subscriptions yet.

@IsraelOrtuno
Copy link
Owner

Just got an email from Pipedrive itself, will implement it ASAP:

Hi Israel,

My name is Elina and I'm a Technical Writer in Pipedrive. I'm writing to let you know that we have released the support for Leads API with 11 new endpoints:

GET /leads
GET /leads/{id}
GET /leadLabels
GET /leadLabels/{id}
GET /leadSources
POST /leads
POST /leadLabels
DELETE /leads/{id}
DELETE /leadLabels/{id}
PATCH /leads/{id}
PATCH /leadLabels/{id}

It'd be great if you could consider adding the support of those endpoints also to your public PHP client for Pipedrive API.

For any questions related to the new endpoints or how to work with them, I've also added our Lead Engineer for Leads, Jakub Kadlubiec, as a cc to this email. Don't hesitate to contact us if you have any questions or concerns.

@iammichiel
Copy link
Contributor

iammichiel commented Jul 28, 2020

Perhaps, Pipedrive itself could sponsor the work? 🤔

IsraelOrtuno added a commit that referenced this issue Oct 20, 2020
@IsraelOrtuno
Copy link
Owner

Will add subscriptions before the end of the week too

@felixjunghans
Copy link

Hi @IsraelOrtuno are there any updates regarding subscriptions?

@kg-bot
Copy link

kg-bot commented Dec 14, 2020

Hi @IsraelOrtuno, when trying to add new lead I always get error Devio/Pipedrive/Exceptions/PipedriveException with message 'expected request body to be sent with application/json content-type', looks like that we can't use form_params as POST request but instead use json for this endpoint?

@IsraelOrtuno
Copy link
Owner

IsraelOrtuno commented Dec 14, 2020

@kg-bot could you update this file in your vendor by adding a third parameter: https://github.com/IsraelOrtuno/pipedrive/blob/master/src/Resources/Basics/Resource.php#L75

return $this->request->post('', $values, ['headers' => ['content-type' => 'application/json']]);

And let me know if this works? I could quickly fix then!

@kg-bot
Copy link

kg-bot commented Dec 14, 2020

@IsraelOrtuno still does not work. I think issue is on this line https://github.com/IsraelOrtuno/pipedrive/blob/master/src/Http/PipedriveClient.php#L102

I've tried changing this to json and it worked.

@IsraelOrtuno
Copy link
Owner

Mmm not sure if this may be a breaking change for other endpoints

@kg-bot
Copy link

kg-bot commented Dec 14, 2020

Let's try some other endpoint that is working with form_params right now, shall we 😄

@kg-bot
Copy link

kg-bot commented Dec 14, 2020

Ok, my project does creation of organisation, person and lead, first two where working with form_params and they also work with json change, last one is only working with json.

@kg-bot
Copy link

kg-bot commented Dec 16, 2020

Any update on this @IsraelOrtuno?

@IsraelOrtuno
Copy link
Owner

@kg-bot PR #101 will fix the issue

@kg-bot
Copy link

kg-bot commented Dec 23, 2020

Perfect, thanks.

@simensen
Copy link
Contributor

#101 was merged, but unclear what more needs to be done for subscriptions. It's possible I can help with that if I had more detail on what still needs to be done.

@mikebastarache
Copy link

I was wondering if there has been any head way in the new Subscription end points? I haven't been able to locate them in the Master branch.

@manshu manshu closed this as completed Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants