For review with Android #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch MR-1-user
On branch MR-1-user
1. User creation test 2. Identifier creation test On branch MR-1-user
On branch MR-1-user
On branch MR-1-user
On branch MR-1-user
6-digit verification code generation by means of Apache Commons Lang On branch MR-1-user
On branch MR-1-user
On branch MR-1-user
On branch MR-1-user
On branch MR-1-user
On branch MR-4-session
On branch MR-4-session
The library provides multiplatform support of date/time classes On branch MR-4-session
On branch MR-4-session
On branch MR-4-session
On branch MR-4-session
On branch MR-4-session
On branch MR-4-session
Use Mockito (v3.6) to mock static method of Clock class so as to have the ability to change system time On branch MR-4-session
On branch MR-1-user
On branch MR-1-user
* Configure website deployment * Add Production, Build and Deploy sections to README * Make FCM initialization optional (for local/debug envs) * Fix Build section of README * Add 'Development with IntelliJ IDEA' section to README
Walingar
approved these changes
Jan 19, 2021
| val name: String, | ||
| val type: String, | ||
| ) { | ||
| fun url(): String = "http://${Server.host}:${Server.port}/attachments/$objectId/$name" |
There was a problem hiding this comment.
Так можно сделать, если сконфигурировать ktor client deserializer, чтобы он игнорировал поле url (потому что оно не в конструкторе). Иначе возникают ошибки, то в android, то в ios...
There was a problem hiding this comment.
Тогда можно сделать extension val ;)
shared/src/commonMain/kotlin/org/itmodreamteam/myrest/shared/error/ServerError.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/org/itmodreamteam/myrest/shared/messaging/MessagingClient.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/org/itmodreamteam/myrest/shared/messaging/MessagingClientImpl.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/org/itmodreamteam/myrest/shared/messaging/NotificationClient.kt
Show resolved
Hide resolved
| private val restaurantClient: RestaurantClient | ||
| ) : ViewModel() { | ||
| private val _restaurants = MutableLiveData<List<RestaurantInfo>>() | ||
| val restaurants: LiveData<List<RestaurantInfo>> = _restaurants |
| val search = restaurantClient.search(keyword, Pageable(0, 10)) | ||
| // TODO debug x4 | ||
| val test = mutableListOf<RestaurantInfo>() | ||
| for (i in (0..3)) { |
| import dagger.hilt.android.HiltAndroidApp | ||
|
|
||
| @HiltAndroidApp | ||
| class MyRestApplication : Application() { |
| private fun getMyRestaurants() = GlobalScope.launch { | ||
| try { | ||
| val restaurants = props.restaurantClient.getRestaurantsOfUser() | ||
| setState(State(state.me, restaurants)) |
There was a problem hiding this comment.
state.copy(restaurants = restaurants)
There was a problem hiding this comment.
Насколько я знаю, в kotlin-react больше любят делать state интерфейсом и проперти var, чтобы тут вызывать setState { restaurants = restaurants }
There was a problem hiding this comment.
Да, так было бы лучше
| class SignInComponent(props: Props) : RComponent<SignInComponent.Props, SignInComponent.State>(props) { | ||
|
|
||
| init { | ||
| state = State(null) |
There was a problem hiding this comment.
Я думаю, так не очень хорошо делать, лучше использовать state который предоставляет родитель
* Add getById method for RestaurantClient * Disable auth for public method
* Add ability to update profile * Fix tests
Add skeleton of sign up activity Add manual dependency injection Auto upgrade of gradle dependencies
Add DI using hilt Enable data binding Fix java versions (hilt doesn't work with 11) Add some dummy fragments
Add toolbar Add material components Set theme to NoActionBar (to see the back icon?)
Implement auto-recovering session logic Remove old activities from manifest
Add profile view Remove obsolete debug search activities Auto-move to restaurant search if user is signed in
Refresh session Add stub navigation
Add assisted DI support
Fix singletons Dynamic menu depending on global employee mode
Implement logout Setup navigation root destinations
Remove signUp fragment Add ability to change profile data Global timer for signIn action
AlexIvchenko
force-pushed
the
MR-68-login
branch
from
7223733
to
1987be2
Compare
Remove urls when it's not needed
Add info about table to reservation card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to all the code as in #89, this PR contains the latest android module code, though the checks fail