Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tile Component #2

Merged
merged 5 commits into from
Jul 26, 2020
Merged

Add Tile Component #2

merged 5 commits into from
Jul 26, 2020

Conversation

TechSolomon
Copy link
Collaborator

@TechSolomon TechSolomon commented Jul 26, 2020

Some notes:

  • I had some issues running the COMMIT-DOCS-DIST command since this was my first component-based contribution to the Svelte-UIKit3 project. Please review commit 759aeb3, in addition to the other changes, because it may be missing some critical documentation for our Storybook live publication.
  • I followed the examples in the UIkit Tile documentation, but have not yet included references to tile padding.
  • Also, feel free to check and adjust the naming convention of the Style knob to make it consistent with the other component. I will also need more clarification with the blank/default list item for future reference. Thanks!

To-do (8th item from issue #1):

  • Add the width action

This pull request resolves #1.

@TechSolomon TechSolomon added the enhancement New feature or request label Jul 26, 2020
@TechSolomon TechSolomon requested a review from ItsMeBrianD July 26, 2020 12:33
src/Tile/README.md Outdated Show resolved Hide resolved
Copy link
Owner

@ItsMeBrianD ItsMeBrianD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, well done!

@ItsMeBrianD ItsMeBrianD merged commit 08ab5e3 into master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Tile Component
2 participants