Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for retrieving supported UUIDs for connecting to devices #40

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

Gyurme
Copy link

@Gyurme Gyurme commented May 30, 2018

I noticed that there are devices (third party headsets etc) that do not always support the universal serial UUIDs that are recommended by the guides.
I would like to add a method that allows you to fetch the list of supported UUIDs that can be used to connect to a device.

…hat can be used to connect to a device. Useful for connecting to devices that may not support the standard UUIDs.
@MrSlateZB
Copy link

If this is added, I would personally like to see an Observable<List> instead of Observable<Parcelable[]>. Additionally, the Observable should probably complete once all UUIDS are emitted since it sounds like only a single intent is sent with the UUIDs.

@IvBaranov
Copy link
Owner

Sorry for this delay.

@IvBaranov IvBaranov merged commit 7578ca1 into IvBaranov:rxjava-2.x Oct 22, 2018
@Gyurme
Copy link
Author

Gyurme commented Oct 22, 2018

No problem, thanks for accepting and adding the onComplete and removing the extra onDispose(), I was a little new to RxJava2 when I made the request :)

@IvBaranov
Copy link
Owner

Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants