Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connectAsServer & connectAsClient which mirror observeBluetoothSocket & observeConnectDevice but return Single. #44

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

vanniktech
Copy link
Contributor

There's only one emission so they should be returning a Single. Decided to deprecate the old ones in order to not make any incompatible changes. If someone still needs an Observable they can use .toObservable() on the new methods if we ever remove the deprecated methods.

…cket & observeConnectDevice but return Single.
@vanniktech
Copy link
Contributor Author

CI seems to be flaky:

> Could not resolve all files for configuration ':classpath'.
   > Could not find lint-gradle-api.jar (com.android.tools.lint:lint-gradle-api:26.1.2).
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/lint/lint-gradle-api/26.1.2/lint-gradle-api-26.1.2.jar

@IvBaranov
Copy link
Owner

First of all, thank you for taking your time to review and contribute.
I looked through all PRs and now I am starting to merge. Travis build passed on all of them as well.

@IvBaranov IvBaranov merged commit d9ef682 into IvBaranov:rxjava-2.x Oct 29, 2018
@vanniktech vanniktech deleted the connect branch October 29, 2018 09:22
@vanniktech
Copy link
Contributor Author

Cheers. Thanks for the library!

@vanniktech
Copy link
Contributor Author

Would appreciate a new release with all of the new features.

@IvBaranov
Copy link
Owner

IvBaranov commented Oct 29, 2018

Sure.
UPD. Release 2.0.3 is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants