Upgrade to AndroidX. #54
Conversation
| @@ -2,7 +2,6 @@ apply plugin: 'com.android.application' | |||
|
|
|||
| android { | |||
| compileSdkVersion COMPILE_SDK_VERSION | |||
| buildToolsVersion BUILD_TOOLS_VERSION | |||
There was a problem hiding this comment.
Android Gradle Plugin handles this by default now
| @@ -24,6 +23,5 @@ android { | |||
|
|
|||
| dependencies { | |||
| implementation project(':rxbluetooth') | |||
| implementation "com.android.support:appcompat-v7:$SUPPORT_LIBRARY_VERSION" | |||
| implementation "com.android.support:design:$SUPPORT_LIBRARY_VERSION" | |||
|
|
||
| # Minimum SDK version (lowest SDK platform to target) | ||
| MIN_SDK_VERSION=11 | ||
| MIN_SDK_VERSION=14 |
There was a problem hiding this comment.
Required by AndroidX
There was a problem hiding this comment.
Do you think min SDK version 11 deserves its own branch or it will be ok to leave it?
There was a problem hiding this comment.
Nah. AndroidX requires 14. And everyone else does too.
There was a problem hiding this comment.
I still feel bad about moving up min SDK version of library. If that should be a major version change so 2.x.x branch to be left for 11+ and 3.x.x for 14+ and androidx?
There was a problem hiding this comment.
No one is using minSdk < 14 and if so they can use the old version since they won't be using AndroidX anyways.
| BINTRAY_RELEASE=0.8.1 | ||
|
|
||
| # Maven | ||
| USER_ORG=ivbaranov | ||
| GROUP=com.github.ivbaranov | ||
| ARTIFACT_ID=rxbluetooth2 | ||
|
|
||
| android.useAndroidX=true | ||
| android.enableJetifier=false |
There was a problem hiding this comment.
We're AndroidX only. ❤️
|
A new version. Probably 2.1.0 would be highly appreciated. Thanks! |
rxbluetooth/build.gradle
Outdated
| @@ -17,7 +16,7 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation "com.android.support:support-annotations:$SUPPORT_LIBRARY_VERSION" | |||
| implementation 'androidx.annotation:annotation:1.0.1' | |||
There was a problem hiding this comment.
Also I would love androidx version to be in gradle.properties like the rest verisions to be consistent.
There was a problem hiding this comment.
With AndroidX each of those will have different versions. They are no longer pushed with the same version at the same time.
If you still want me to move them, let me know and I'll!
There was a problem hiding this comment.
Yep, I mean all version names and numbers are in gradle.properties. Let it be ANDROIDX_ANNOTATION for example.
There was a problem hiding this comment.
Did that @IvBaranov
|
|
|
I've seen the release tag. Thanks for pushing it out! :) |
No description provided.