feat: Add toggle for showing previous title suggestions in transactio… (

#3466) * feat: Add toggle for showing previous title suggestions in transaction editor * remove showTitleSuggestion state * removed showTitleSuggestions state
Ivy-Apps · Sep 3, 2024 · 0ff49ef · 0ff49ef
1 parent 607f6b2
commit 0ff49ef
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 10 deletions.
diff --git a/screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt b/screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
@@ -222,7 +222,11 @@ class EditTransactionViewModel @Inject constructor(
 
     @Composable
     private fun getTitleSuggestions(): ImmutableSet<String> {
-        return titleSuggestions.value
+        return if (features.showTitleSuggestions.asEnabledState()) {
+            titleSuggestions.value
+        } else {
+            persistentSetOf()
+        }
     }
 
     @Composable

diff --git a/screen/planned-payments/src/main/java/com/ivy/planned/edit/EditPlannedScreen.kt b/screen/planned-payments/src/main/java/com/ivy/planned/edit/EditPlannedScreen.kt
@@ -124,7 +124,6 @@ private fun BoxWithConstraintsScope.UI(
                 titleTextFieldValue = it
             },
             suggestions = emptySet(), // DO NOT display title suggestions for "Planned Payments"
-
             onTitleChanged = { onEvent(EditPlannedScreenEvent.OnTitleChanged(it)) },
             onNext = {
                 when {

diff --git a/shared/domain/src/main/java/com/ivy/domain/features/BoolFeature.kt b/shared/domain/src/main/java/com/ivy/domain/features/BoolFeature.kt
@@ -19,21 +19,22 @@ class BoolFeature(
     val key: String,
     val name: String? = null,
     val description: String? = null,
+    private val defaultValue: Boolean = false
 ) {
     @Composable
     fun asEnabledState(): Boolean {
         val context = LocalContext.current
         val featureFlag = remember { enabledFlow(context) }
-            .collectAsState(false).value
-        return featureFlag ?: false
+            .collectAsState(defaultValue).value
+        return featureFlag ?: defaultValue
     }
 
     suspend fun isEnabled(appContext: Context): Boolean =
-        enabledFlow(appContext).first() ?: false
+        enabledFlow(appContext).first() ?: defaultValue
 
     fun enabledFlow(appContext: Context): Flow<Boolean?> = appContext.dataStore
         .data.map {
-            it[featureKey]
+            it[featureKey] ?: defaultValue
         }
 
     suspend fun set(appContext: Context, enabled: Boolean) {

diff --git a/shared/domain/src/main/java/com/ivy/domain/features/Features.kt b/shared/domain/src/main/java/com/ivy/domain/features/Features.kt
@@ -4,6 +4,7 @@ interface Features {
     val sortCategoriesAlphabetically: BoolFeature
     val compactAccountsMode: BoolFeature
     val compactCategoriesMode: BoolFeature
+    val showTitleSuggestions: BoolFeature
 
     val allFeatures: List<BoolFeature>
 }
diff --git a/shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt b/shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
@@ -25,10 +25,18 @@ class IvyFeatures @Inject constructor() : Features {
         description = "Activates a more streamlined and space-efficient interface for the \"Categories\" Screen"
     )
 
+    override val showTitleSuggestions = BoolFeature(
+        key = "show_title_suggestions",
+        name = "Show previous title suggestions",
+        description = "Enables display of previous transaction titles when editing or creating a new transaction",
+        defaultValue = true
+    )
+
     override val allFeatures: List<BoolFeature>
         get() = listOf(
             sortCategoriesAlphabetically,
             compactAccountsMode,
-            compactCategoriesMode
+            compactCategoriesMode,
+            showTitleSuggestions
         )
 }
diff --git a/temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/edit/core/Title.kt b/temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/edit/core/Title.kt
@@ -42,13 +42,11 @@ fun ColumnScope.Title(
     type: TransactionType,
     titleFocus: FocusRequester,
     initialTransactionId: UUID?,
-
     titleTextFieldValue: TextFieldValue,
     setTitleTextFieldValue: (TextFieldValue) -> Unit,
     suggestions: Set<String>,
-    scrollState: ScrollState? = null,
-
     onTitleChanged: (String?) -> Unit,
+    scrollState: ScrollState? = null,
     onNext: () -> Unit,
 ) {
     IvyTitleTextField(