Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Commit

Permalink
Attempt #2 to fix the internal_release.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
ILIYANGERMANOV committed Jul 6, 2024
1 parent 9d84dc3 commit 902261b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
18 changes: 8 additions & 10 deletions .github/workflows/internal_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ jobs:
internal_release:
runs-on: ubuntu-latest
outputs:
github_release_url: ${{ steps.create_release.outputs.github_release_url }}
github_release_url: ${{ steps.create_release.outputs.upload_url }}

steps:
- name: Checkout GIT
uses: actions/checkout@v4
with:
fetch-depth: 0 #Fetch all history for all branches and tags
fetch-depth: 0 # Fetch all history for all branches and tags

- name: Setup Java SDK
uses: actions/setup-java@v4
Expand All @@ -32,15 +32,15 @@ jobs:
run: bundle install
#----------------------------------------------------

#Security
# Security
- name: Validate Gradle Wrapper checksum
uses: gradle/wrapper-validation-action@v3

- name: Make Gradle Wrapper (gradlew) executable
run: chmod +x gradlew
#----------------------------------------------------

#Optimization
# Optimization
- name: Enable Gradle Wrapper caching (optimization)
uses: actions/cache@v4
with:
Expand All @@ -52,7 +52,7 @@ jobs:
${{ runner.os }}-gradle-
#---------------------------------------------------

#Decode Secrets for production build
# Decode Secrets for production build
- name: Create JKS for prod signing
run: |
echo "$SIGNING_KEYSTORE_JKS" > sign.jks.b64
Expand All @@ -77,7 +77,7 @@ jobs:
name: lint-release-report.html
path: app/build/reports/lint-results-release.html

#Fastlane: Build production .aab and release it to Internal Testing
# Fastlane: Build production .aab and release it to Internal Testing
- name: Build production App Bundle
run: bundle exec fastlane production_build
env:
Expand All @@ -99,16 +99,15 @@ jobs:
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_STORE_PASSWORD }}
#--------------------------------------------------------------------------

#Create GitHub release
# Bullrich/generate-release-changelog@master doesn't run on macos-latest
# Create GitHub release
- name: Prepare changelog for GitHub Release
uses: Bullrich/generate-release-changelog@master
id: Changelog
env:
REPO: ${{ github.repository }}

- name: Create GitHub Release
if: always() #Execute even the generation of changelog has failed
if: always() # Execute even if the generation of changelog has failed
id: create_release
uses: actions/create-release@latest
env:
Expand All @@ -120,7 +119,6 @@ jobs:
${{ steps.Changelog.outputs.changelog }}
draft: false
prerelease: false
run: echo "github_release_url=${{ steps.create_release.outputs.upload_url }}" >> $GITHUB_ENV

build_demo_apk_and_announce:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ paparazzi = "1.3.3"
min-sdk = "28"
compile-sdk = "34"
version-name = "4.6.7"
version-code = "167"
version-code = "168"
jvm-target = "17"


Expand Down

0 comments on commit 902261b

Please sign in to comment.