Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[FEATURE] Add color to accounts labels in transactions list. #3545

Closed
3 tasks done
DrwOOx opened this issue Sep 20, 2024 · 6 comments · Fixed by #3628
Closed
3 tasks done

[FEATURE] Add color to accounts labels in transactions list. #3545

DrwOOx opened this issue Sep 20, 2024 · 6 comments · Fixed by #3628
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user

Comments

@DrwOOx
Copy link

DrwOOx commented Sep 20, 2024

Please confirm the following:

  • I've checked the current issues for duplicate issues.
  • I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
  • My issue is well-defined and describes how it should be implemented from UI/UX perspective.

What do you want to be added or improved?

Would it be possible for that "label" to appear in the color of the account instead of black... Like it happens with the categories in all transactions list.

Why do you need it?

It would provide more clarity to know to which account each record belongs with a quick query to the transaction list.

image

How do you imagine it?

It would be similar to how the categories label is shown in the transaction list but for the accounts label, showing the color that these have defined in their setting in the accounts section.

@DrwOOx DrwOOx added the user request Feature/improvement requested by an user label Sep 20, 2024
@DrwOOx DrwOOx changed the title [FEATURE] [FEATURE] Add color to accounts labels in transacctions list. Sep 20, 2024
@DrwOOx DrwOOx changed the title [FEATURE] Add color to accounts labels in transacctions list. [FEATURE] Add color to accounts labels in transactions list. Sep 20, 2024
@ivywallet
Copy link
Collaborator

Thank you @DrwOOx for raising Issue #3545! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV
Copy link
Collaborator

This should be an IvyFeatures setting that's disabled by default

@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Sep 20, 2024
@DrwOOx
Copy link
Author

DrwOOx commented Sep 20, 2024

This should be an IvyFeatures setting that's disabled by default

Would it be possible to add the advanced configuration setting to be able to activate it? Thank you.

Regards.

@ILIYANGERMANOV
Copy link
Collaborator

That's the idea - an advanced setting. The reason why it'll be off by default is because the UI will look too colorful with both categories and accounts => it'll be a distraction. But there's no problem having it as a setting

@shamim-emon
Copy link
Member

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @shamim-emon! 🎉
Issue #3545 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user
Projects
None yet
4 participants