Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vietnamese translation, add new key string for some hardcode text… #3095

Merged
merged 3 commits into from
Apr 6, 2024

Conversation

isaacnguyen0809
Copy link
Contributor

@isaacnguyen0809 isaacnguyen0809 commented Apr 5, 2024

…, remove redundant key, fix padding and text style

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

What's changed?

Add Vietnamese translation

Screenshot

Screenshot_20240406_022612
Screenshot_20240406_022642

Describe with a few bullets what's new:

  • Remove redundant key string(Some strings have the same data but different keys)
  • Key definitions for some strings are still hardcoded
  • Slightly edited the interface and style of the text

Risk Factors

No

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @isaacnguyen0809 a few things:

  • Update branch
  • Fix Detekt

There might make sense some strings to be duplicated if in future we want to provide different texts for the different screens. Use common sense and your best judgment

…, remove redundant key, fix padding and text style
@isaacnguyen0809
Copy link
Contributor Author

isaacnguyen0809 commented Apr 6, 2024

@ILIYANGERMANOV some updates

  • I fixed the detekt in 1 place, but the remaining 3 places are quite large, so I think i won't touch this part in this PR because it will have to refactor the function a lot and I'm afraid it will have a big impact.(Can we skip this part in this PR :D and we can create a ticket so I'll refactor it and test it thoroughly)-(image below)

image

  • Regarding duplicate strings, I justa accidently found one, and I believe it is redundant because the two uses have the same UI, the same text data but different key strings.(image below)

image
image

@ILIYANGERMANOV
Copy link
Collaborator

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯 Fix the Detekt using @Suppress and we can merge

@ILIYANGERMANOV ILIYANGERMANOV merged commit 4d55e4d into Ivy-Apps:main Apr 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Vietnamese Language Support
2 participants