Removed all code related to sign in through google from app.

[ahsanishaq721]

…ts and files.

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

• The PR is submitted to the main branch.
• I've read the Contribution Guidelines and my PR doesn't break the rules.
• I've read and understand the Developer Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
• 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

What's changed?

Describe with a few bullets what's new:

• ...

• ...

Risk factors

What may go wrong if we merge your PR?

• ...
• ...

In what cases won't your code work?

• ...
• ...

Does this PR close any GitHub issues?

• Closes Remove code related to google sign in #3314

Troubleshooting CI failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

[ILIYANGERMANOV]

@ahsanishaq721 fix merge conflicts and add "Closes #ISSUE_NUMBER" to the PR description

[ahsanishaq721]

Added close in PR description but not understanding the merging conflicts. Can you help? What i have to do

[ILIYANGERMANOV]

click "Resolve Conflicts" and make sure that both Google dependencies are removed

[ahsanishaq721]

@ILIYANGERMANOV done with resolved conflicts.

[ILIYANGERMANOV]

@ILIYANGERMANOV done with resolved conflicts.

@ahsanishaq721 now you need to fix the PR checks. Detekt is failing. Use the guide from the description

[suyash01]

@ahsanishaq721 run gradle task for detekt in local and fix the issues until build is successful. For windows you can run .\gradlew detekt in the root of your project folder.

[ahsanishaq721]

Thank u @suyash01

[ahsanishaq721]

@ILIYANGERMANOV I am facing gradle issues, can I do some fixes in gradle in same branch and should i make another PR?

[ahsanishaq721]

@ILIYANGERMANOV facing this issue while runing detekt command.
My task was to remove google sign in related code which i have done. This is related to existing code. can you help me with that?

[suyash01]

@ILIYANGERMANOV facing this issue while runing detekt command.
My task was to remove google sign in related code which i have done. This is related to existing code. can you help me with that?

There should be detekt lint error message above the build failed error message. It is not highlighted red.

[ahsanishaq721]

@suyash01 what should I do now? now detekt will be passed?

[ILIYANGERMANOV]

@ahsanishaq721 read the CI Troubleshooting guide. Click "Details" on the failed detekt check and you'll see

Property 'style>OptionalWhenBraces' is deprecated. Same functionality is implemented in BracesOnWhenStatements.
/home/runner/work/ivy-wallet/ivy-wallet/app/src/main/java/com/ivy/wallet/RootActivity.kt:207:1: First line in a method block should not be empty [NoEmptyFirstLineInMethodBlock]
/home/runner/work/ivy-wallet/ivy-wallet/app/src/main/java/com/ivy/wallet/RootActivity.kt:29:1: Unused import [NoUnusedImports]
/home/runner/work/ivy-wallet/ivy-wallet/app/src/main/java/com/ivy/wallet/RootActivity.kt:30:1: Unused import [NoUnusedImports]
/home/runner/work/ivy-wallet/ivy-wallet/app/src/main/java/com/ivy/wallet/RootActivity.kt:55:1: Unused import [NoUnusedImports]
/home/runner/work/ivy-wallet/ivy-wallet/screen/onboarding/src/main/java/com/ivy/onboarding/viewmodel/OnboardingViewModel.kt:25:1: Unused import [NoUnusedImports]
/home/runner/work/ivy-wallet/ivy-wallet/screen/onboarding/src/main/java/com/ivy/onboarding/viewmodel/OnboardingViewModel.kt:43:1: Unused import [NoUnusedImports]
/home/runner/work/ivy-wallet/ivy-wallet/app/src/main/java/com/ivy/wallet/RootActivity.kt:71:26: Private property onGoogleSignInIdTokenResult is unused. [UnusedPrivateProperty]
/home/runner/work/ivy-wallet/ivy-wallet/screen/onboarding/src/main/java/com/ivy/onboarding/viewmodel/OnboardingViewModel.kt:49:17: Private property ivyContext is unused. [UnusedPrivateProperty]

[ILIYANGERMANOV]

There are unused imports and fields

[ahsanishaq721]

Ok, but i didn't import or add anything new in code. I have just removed the google sign in related code, which was my task.

[ahsanishaq721]

@ILIYANGERMANOV creating PR again

[ahsanishaq721]

@ILIYANGERMANOV I have done previously mentioned tasks mentioned by detekt. Now it is showing a longer list. These are existing issues and not related to my task I think.

[ILIYANGERMANOV]

@ILIYANGERMANOV I have done previously mentioned tasks mentioned by detekt. Now it is showing a longer list. These are existing issues and not related to my task I think.

You can either:

• fix them
• use Suppress for the harder
• or add a Detekt baseline

Read the Troubleshooting guide

[ahsanishaq721]

i have run ./gradlew detektBaseline command but it failed the build process.

[ILIYANGERMANOV]

@ahsanishaq721 can you trying using @Suppress for the hard fixes and fix the easier one? It shouldn't be that hard. Last week, I fixed like 400 or so 😅

[ahsanishaq721]

@ILIYANGERMANOV At last all checks have been passed. I was first time working on detekt so sorry for delay.

[ILIYANGERMANOV]

Nice job fixing the CI 👏 Found some issues that we need to fix before merging

[ahsanishaq721]

@ILIYANGERMANOV I have done changes which you have requested. Please check. The checks are in progress.

[ILIYANGERMANOV]

LGTM!

[ahsanishaq721]

Now, lint have failed. It happened for the first time. Why?

[ILIYANGERMANOV]

Now, lint have failed. It happened for the first time. Why?

Retrying it, seems like a GitHub Actions problem

[ahsanishaq721]

Ok done. Nice to work with you. It was my first small contribution to any open source project.