Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3342 #3346

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix issue 3342 #3346

merged 2 commits into from
Jul 17, 2024

Conversation

LexLeontiev
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

Screen_recording_20240717_003727.webm

What's changed?

  • add material-icons-extended library
  • add duplicate button to the edit transaction screen
  • use icon from material-icons-extended to maintain consistency with the material style
  • duplicate transaction on clicking the duplicate button and close the transaction screen
  • don't show the duplicate button for editing planned payments (that doesn't make any sense)

Risk factors

I've tested the new code locally on real device and emulator, with both themes and for both expenses and incomes. However, I was not able to test the duplication of transfers because they are broken now.

Does this PR close any GitHub issues?

Troubleshooting CI failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 💯

@ILIYANGERMANOV ILIYANGERMANOV merged commit 1a46521 into Ivy-Apps:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add option to create duplicate of an expense or income
2 participants