This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Fix: Prevent consecutive operator input in CalculatorModal #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved an issue in the CalculatorModal where consecutive operators could be added, resulting in invalid expressions. - Updated the handleOperator function to ensure only one operator is added at a time. - Replaced the last operator if a new operator is pressed. - Ensured the input behaves like a standard calculator. This change improves the user experience by preventing invalid expressions and aligning the calculator's behavior with user expectations.
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/modal/edit/CalculatorModal.kt
Outdated
Show resolved
Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/modal/edit/CalculatorModal.kt
Show resolved
Hide resolved
I dont get it ....... |
Can you input the following expression when adjusting balance? |
neg.mp4If you mean this then yes |
ILIYANGERMANOV
approved these changes
Jul 22, 2024
|
It's ready to merge |
|
@akashs056 you missed to add which is closed by this PR and now I have to manually go and close it. Not a big deal but so you know for future PRs |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
What's changed?
Resolved an issue in the CalculatorModal where consecutive operators could be added, resulting in invalid expressions.
This change improves the user experience by preventing invalid expressions and aligning the calculator's behavior with user expectations.
Before
https://github.com/user-attachments/assets/c4cb087d-e360-44b1-90fd-38f3436e5e04
After:
https://github.com/user-attachments/assets/085816dc-9ad7-459a-b48e-c35e3bd649ad