Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement maximum text length constraint for interval input field #3371

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

akashs056
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

  • Set a maximum text length of three digits for the interval input field.
  • Adjusted the button width to ensure it stays perfectly within the screen.
  • Applied the logic that the maximum interval can only be up to 365 days, which fits within three digits.

Before

WhatsApp.Video.2024-07-27.at.12.53.01_9ee713fd.mp4

After

WhatsApp.Video.2024-07-27.at.12.50.13_129e9aad.mp4

Does this PR close any GitHub issues? (do not delete)

@akashs056
Copy link
Contributor Author

@ILIYANGERMANOV Its ready to merge

@ILIYANGERMANOV ILIYANGERMANOV merged commit ffeb9f8 into Ivy-Apps:main Jul 27, 2024
9 checks passed
@akashs056 akashs056 deleted the fix-issue-3349 branch July 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlimited repeats in Planned payments Screen hide "Time Component"
3 participants