Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-issue-3438 #3476

Merged
merged 4 commits into from
Sep 6, 2024
Merged

fix-issue-3438 #3476

merged 4 commits into from
Sep 6, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Sep 5, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've fixed [BUG] Updating a transaction from a report does not get reflected

Risk factors

What may go wrong if we merge your PR?

  • No know case

In what cases won't your code work?

  • No know case

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@shamim-emon shamim-emon marked this pull request as ready for review September 5, 2024 16:14
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. @shamim-emon what was the root cause of the bug?
  2. Can you submit a screen recording of the fix?

I don't have enough context and don't understand the fix

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 6, 2024
@shamim-emon
Copy link
Member Author

  1. @shamim-emon what was the root cause of the bug?
  2. Can you submit a screen recording of the fix?

I don't have enough context and don't understand the fix

@ILIYANGERMANOV
1.When removing/updating any filter we weren't updating linked data, so filtered result persisted.
2. Below is the video of the after-fix

video.mp4

@ILIYANGERMANOV ILIYANGERMANOV merged commit 79e457b into Ivy-Apps:main Sep 6, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3438 branch September 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Updating a transaction from a report does not get reflected
2 participants