Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

fix-issue-3481 #3482

Merged
merged 4 commits into from
Sep 9, 2024
Merged

fix-issue-3481 #3482

merged 4 commits into from
Sep 9, 2024

Conversation

akashs056
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

WhatsApp.Video.2024-09-07.at.17.28.31_af53b7dc.mp4

What's changed?

used the new Time Provider APIs

Before After
{media} {media}
{media} {media}

Risk factors

What may go wrong if we merge your PR?

  • ...
  • ...

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 7, 2024
@akashs056
Copy link
Contributor Author

@ILIYANGERMANOV I’ve migrated the default time picker to the new one, but I’m facing an issue. When I update the time from the ViewModel using the loan record dateTime, it works fine in edit mode. However, when creating a new record and loanRecordModalData.value.loanRecord is null, the time doesn’t update properly. Should I create a separate state for handling this time, or do you have any other suggestions? Please take a look at the code.

@suyash01
Copy link
Contributor

suyash01 commented Sep 8, 2024

@ILIYANGERMANOV I’ve migrated the default time picker to the new one, but I’m facing an issue. When I update the time from the ViewModel using the loan record dateTime, it works fine in edit mode. However, when creating a new record and loanRecordModalData.value.loanRecord is null, the time doesn’t update properly. Should I create a separate state for handling this time, or do you have any other suggestions? Please take a look at the code.

handling for save and edit scenarios is present here

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a screen recording after the latest changes and we can merge

@akashs056
Copy link
Contributor Author

Provide a screen recording after the latest changes and we can merge

The latest changes is not working as expected see i am commented the issue oi am facing please suggest your opinion should i modify the states or any other approach.....

@akashs056
Copy link
Contributor Author

Screen recording of my latest changes and works perfectly fine

WhatsApp.Video.2024-09-09.at.13.17.59_c43f297b.mp4

@ILIYANGERMANOV ILIYANGERMANOV merged commit 485b6d4 into Ivy-Apps:main Sep 9, 2024
9 checks passed
@akashs056 akashs056 deleted the fix-issue-3481 branch September 9, 2024 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Time Not Applied Correctly in Loans – Set Time Behind by 1 Hour (-1h)
3 participants