-
Notifications
You must be signed in to change notification settings - Fork 665
Conversation
screen/loans/src/main/java/com/ivy/loans/loandetails/LoanDetailsScreen.kt
Outdated
Show resolved
Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/components/DateTimeRow.kt
Outdated
Show resolved
Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/components/DateTimeRow.kt
Outdated
Show resolved
Hide resolved
@ILIYANGERMANOV I’ve migrated the default time picker to the new one, but I’m facing an issue. When I update the time from the ViewModel using the loan record dateTime, it works fine in edit mode. However, when creating a new record and |
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/components/DateTimeRow.kt
Outdated
Show resolved
Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/modal/LoanModal.kt
Outdated
Show resolved
Hide resolved
handling for save and edit scenarios is present here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide a screen recording after the latest changes and we can merge
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/components/DateTimeRow.kt
Outdated
Show resolved
Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/legacy/ui/theme/modal/LoanModal.kt
Outdated
Show resolved
Hide resolved
screen/loans/src/main/java/com/ivy/loans/loandetails/LoanDetailsViewModel.kt
Show resolved
Hide resolved
The latest changes is not working as expected see i am commented the issue oi am facing please suggest your opinion should i modify the states or any other approach..... |
Screen recording of my latest changes and works perfectly fine WhatsApp.Video.2024-09-09.at.13.17.59_c43f297b.mp4 |
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
WhatsApp.Video.2024-09-07.at.17.28.31_af53b7dc.mp4
What's changed?
used the new Time Provider APIs
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.