Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Search Functionality In Category Screen #3499

Merged
merged 13 commits into from
Sep 13, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Sep 12, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I have added optional search functionality in Category Screen
Categoy.Screen.Search.Bar.mp4

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@shamim-emon shamim-emon marked this pull request as draft September 12, 2024 16:57
@shamim-emon shamim-emon marked this pull request as ready for review September 12, 2024 17:32
@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 13, 2024
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👏

@ILIYANGERMANOV
Copy link
Collaborator

ILIYANGERMANOV commented Sep 13, 2024

@shinebrillant great work! As a feedback, try putting meaningful commit message describing the change in the commit briefly l:

  • "fix-issue-3488" 12 times isn't very helpful for reviewers

@ILIYANGERMANOV ILIYANGERMANOV merged commit 8308d88 into Ivy-Apps:main Sep 13, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Category Search Bar
2 participants