Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomBar added on Exchange Rates Screen #3508

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Sep 14, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

  • I've added Bottom bar (having navigation back button) on Exchange Rates screen

Before(Left) | After(Right)

Dark
light

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 14, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 16bd614 into Ivy-Apps:main Sep 15, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3504 branch September 16, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Navigation Back Button In Exchange Rates
2 participants