Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Create True Black mode for amoled screens #3538

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

paulolima18
Copy link
Contributor

@paulolima18 paulolima18 commented Sep 17, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

Screen.Recording.2024-09-17.at.12.15.13.mov

What's changed?

Describe with a few bullets what's new:

  • I've added a true black mode for amoled screens
Before After
Screenshot 2024-09-17 at 12 15 04 Screenshot 2024-09-17 at 12 14 57

Risk factors

What may go wrong if we merge your PR?

  • People might not like the same icon for dark mode and true black mode
  • ...

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some comments. Apply them, fix the CI and we can merge. Nice work 💯

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 17, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit e91c012 into Ivy-Apps:main Sep 19, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants