Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix issue 3565 #3573

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Fix issue 3565 #3573

merged 5 commits into from
Oct 2, 2024

Conversation

ikergcalvino
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

Describe with a few bullets what's new:

  • I've added Galician translation to the app.

Risk factors

What may go wrong if we merge your PR?

  • Depending on string length (some devices can have cut sentences).
  • Galician translation could have some typos.

In what cases won't your code work?

  • It should work always (only translation).

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikergcalvino the project doesn't build. You have incorrectly escaped strings in the translations

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Oct 1, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit aa93f06 into Ivy-Apps:main Oct 2, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRANSLATION] Galician
2 participants