This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Closes #18; implemented swipe gesture to open more menu screen #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILIYANGERMANOV
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Hi @TimmyCoder your implementation is elegant, doesn't break performance, and after minor tweaks should work properly. I'll accept your PR and do the improvements myself. Thank you for your contribution!
| .navigationBarsPadding() | ||
| .pointerInput(Unit) { | ||
| detectDragGestures( |
There was a problem hiding this comment.
detectVerticalDragGesture() should be used and only swipe in downwards direction should be detected
|
|
||
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .statusBarsPadding() | ||
| .offset { | ||
| IntOffset(offset.x.roundToInt(), offset.y.roundToInt()) |
There was a problem hiding this comment.
offset.x.roundToInt() can be replaced just with 0 no need to round
ILIYANGERMANOV
pushed a commit
that referenced
this pull request
Nov 8, 2021
ILIYANGERMANOV
pushed a commit
that referenced
this pull request
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
developbranch.Put an
xin the boxes that apply.[x]Pull Request Type
Please check the type of change your PR introduces:
Put an
xin the boxes that apply.Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
What's changed?
Describe with a few bullets what's new:
This PR template style was inspired by ionic-framework.