Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CI/CD) Actions workflow overhaul #1128

Merged
merged 5 commits into from
Dec 25, 2022
Merged

(CI/CD) Actions workflow overhaul #1128

merged 5 commits into from
Dec 25, 2022

Conversation

taysta
Copy link
Contributor

@taysta taysta commented Oct 19, 2022 •
edited
Loading

This pull request updates:

  • Action runner environments to their latest versions. (windows-2022, ubuntu-22.04, macos-12) [1]
  • Action runners to their latest versions. (Fixes nodejs12 and other workflow deprecation warnings)

The workflow can be run multiple ways:

  • Manually, targeting any branch from the actions tab of the repository. [1]
  • Automatically on commits, pull-requests and releases to the master branch.

It also adds releases to the workflow through two options:

  1. Latest Build, triggered on all commits, pull requests and releases to the master branch. This essentially provides the same effect as the nightly OpenJK builds that users may have been previously accustomed to.
  2. Manual release, simply create a release, add a version tag targeting the master branch and the workflow will trigger and upload the release files if successful. [1][2][3][4]

I ran a manual workflow action on this PR branch with all builds passing here.

Credits to

@taysta
Workflow overhaul
2a27be7 
- Update environment & action runners
- Add automatic latest releasing as well as manual releases
- Add portable & non-portable, release, debug builds
@taysta
Fix ubuntu x86 toolchain path
9c099fb
@taysta
Only run automatically on master branch
068fa22
@taysta
Merge branch 'master' into openjk-cicd
da44a24
@ensiform
Copy link
Member

Can we still get it pushing to builds.openjk?

@taysta
Copy link
Contributor Author

taysta commented Oct 19, 2022 •
edited
Loading

Github doesn't push to builds.openjk

builds.openjk runs weekly, it just clones this repo and uploads the files from the build it runs. It's kind of pointless anyway since across the last 4 commits there has been been 28 builds.

@taysta
Change build/upload/release options
2854f96 
With the following commit, the set-up will be as follows:

Build:
- Windows/WinXP 32/64 Portable/Non-Portable Release/Debug
- Linux 32/64 Non-Portable Release/Debug
- MacOS 64 Non-Portable Release/Debug

Release:
- Windows/WinXP 32 Non-Portable Release
- Linux 32/64 Non-Portable Release
- MacOS 64 Non-Portable Release

Optional (Artifacts uploaded but not included in release):
- Windows/WinXP 64 Portable/Non-Portable Release
- Windows/WinXP 32 Portable Release
@fellfalafel
Copy link

merg pls

1 similar comment
@bartrpe
Copy link

bartrpe commented Dec 23, 2022

merg pls

@xycaleth
Copy link
Member

Thanks for the contribution! Not sure it was really necessary to build portable and non-portable for everything but no harm in doing so :)

@xycaleth xycaleth merged commit 9223dbc into JACoders:master Dec 25, 2022
@Razish Razish mentioned this pull request Sep 22, 2023
Open
@taysta taysta mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ensiform ensiform ensiform left review comments

@xycaleth xycaleth xycaleth left review comments

@Razish Razish Razish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taysta @ensiform @fellfalafel @bartrpe @xycaleth @Razish