Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the hvplot backend #186

Merged
merged 29 commits into from
May 20, 2024
Merged

Conversation

asewnath
Copy link
Collaborator

@asewnath asewnath commented May 13, 2024

Description

This PR expands upon the hvplot backend introduced in #158. All other diagnostic types are reformatted to have a base class and child classes for each backend. Each base class includes two methods: data_prep and configure_plot. configure_plot is a virtual method that is resolved once a child class for either emcpy or hvplot is instantiated.

figure_driver is updated to reflect these changes

@asewnath asewnath marked this pull request as draft May 13, 2024 17:58
@asewnath
Copy link
Collaborator Author

Moving github action fix to a different PR since it's still not resolved

@asewnath asewnath marked this pull request as ready for review May 16, 2024 18:58
Copy link
Collaborator

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks!

Copy link
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just had the one question on the documentation in the Emcpy* classes.

Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akira. It's great to have a complete backend utilizing hvplot. For future reference you should use git mv to rename files so their history is preserved. I'm concerned that the codes aren't tested and so the interfaces could get broken. Do you plan to add some testing through the notebook style of testing?

@CoryMartin-NOAA CoryMartin-NOAA merged commit 5cf9a62 into develop May 20, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/hvplot_backend_dev branch May 20, 2024 20:29
@asewnath
Copy link
Collaborator Author

Thanks Akira. It's great to have a complete backend utilizing hvplot. For future reference you should use git mv to rename files so their history is preserved. I'm concerned that the codes aren't tested and so the interfaces could get broken. Do you plan to add some testing through the notebook style of testing?

Hi Dan, thanks for the comment. I'll add hvplot testing in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants