-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the hvplot backend #186
Conversation
Moving github action fix to a different PR since it's still not resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, just had the one question on the documentation in the Emcpy* classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akira. It's great to have a complete backend utilizing hvplot. For future reference you should use git mv
to rename files so their history is preserved. I'm concerned that the codes aren't tested and so the interfaces could get broken. Do you plan to add some testing through the notebook style of testing?
Hi Dan, thanks for the comment. I'll add hvplot testing in another PR |
Description
This PR expands upon the hvplot backend introduced in #158. All other diagnostic types are reformatted to have a base class and child classes for each backend. Each base class includes two methods:
data_prep
andconfigure_plot
.configure_plot
is a virtual method that is resolved once a child class for either emcpy or hvplot is instantiated.figure_driver
is updated to reflect these changes