-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final updates required for building unified environment on HPC, cloud, macOS #228
Final updates required for building unified environment on HPC, cloud, macOS #228
Conversation
…al-workflow-env/package.py
…tin/packages/bufr/package.py
@climbfuji not sure why I'm requested as a reviewer here. I'm on leave until Tuesday so if you need a review sooner, we'll need to reach out to someone else. |
Ah no worries, I wanted you to be aware and provide you with the opportunity to tick some of the testing boxes in case you were successful. If enough people test and review beforehand we'll merge it, otherwise it's going to be next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you've tested the relocate-related changes to your satisfaction, then this looks good.
Yes, I've tested them and also the spack developers tested them when we merged those changes upstream a few weeks ago. I am going to see what the CI tests are doing in the spack-stack PR, and also run the build on my mac os with the self-hosted runner later tonight before merging anything. |
Description
A number of unrelated updates and bug fixes required for building the unified environment on HPC, cloud, macOS. All these were tested on the different platforms.
ncl
a variant in global-workflow-env (by default on), and make it conflict with macOSbufr
for long lines in auto-generated code. Note that a similar change was merged into the NCEPLIBS-bufr repository on Feb 15 (Reduce line length for MASTERTABLE replacements NOAA-EMC/NCEPLIBS-bufr#321), which means the workaround here is only needed for versions up to 11.7.1libelf
: also need to runautoreconf
on macOS Intel when using Rosetta 2, not just on native M1This PR has been tested extensively with JCSDA/spack-stack#454