Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new database handle by DataSource #47

Closed
raderio opened this issue Dec 5, 2018 · 3 comments
Closed

Create a new database handle by DataSource #47

raderio opened this issue Dec 5, 2018 · 3 comments
Labels
Milestone

Comments

@raderio
Copy link

raderio commented Dec 5, 2018

In Spring we already have DataSource instance https://docs.oracle.com/javase/8/docs/api/javax/sql/DataSource.html

Can you please add one more method to create a new database handle, likeDB database(DataSource dataSource) into class JDBDT

@edrdo
Copy link
Member

edrdo commented Dec 5, 2018

This shorthand method will be easy to add in the next release (in a few days). Meanwhile, in the current version you should be able to simply use database(ds.getConnection()) i.e. by using https://docs.oracle.com/javase/8/docs/api/javax/sql/DataSource.html#getConnection--

@edrdo edrdo added the feature label Dec 5, 2018
@edrdo edrdo added this to the 1.1.3 milestone Dec 5, 2018
@raderio
Copy link
Author

raderio commented Dec 5, 2018

Thanks

edrdo added a commit that referenced this issue Dec 9, 2018
edrdo added a commit that referenced this issue Dec 9, 2018
@edrdo
Copy link
Member

edrdo commented Dec 11, 2018

@raderio 1.2.0 has been released. Please let me know of any issues.

@edrdo edrdo closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants