The error message always states "you cannot fire" even though you are reloaded

[mustangsami]

Hi there! Love this module. I'm using it in a game with a gunslinger and it's proving super useful, so thanks very much. I had a couple of ideas if you're open to them?

FVTT-PF2e-Ranged-Combat/scripts/ammunition-system/actions/reload-magazine.js

Line 67 in a9e4b0c

showWarning(`${weapon.name} is already loaded with a full magazine.`);

On this line for the error if a magazine cannot be added to a weapon because it's already loaded, states incorrectly that "you cannot fire this weapon", even though the macro used is reload magazine.

I can see that your dialog box here always states this here:

FVTT-PF2e-Ranged-Combat/scripts/utils/utils.js

Line 230 in a9e4b0c

"title": "PF2e Ranged Combat",

I also see that once you close off a dialog box with the "Do not show this again" label, it will never show ANY error again. Is there a way to re-enable it? Perhaps by a macro to add the compendium? They are super useful and rather than remove them entirely, I'd love to see them be a bit more subtle.

Kind regards,
Sami

[JDCalvert]

Hi there, thanks for your appreciation and feedback!

I actually had never realised that I'd allowed that popup to appear for times when you weren't trying to fire a weapon, I'll have to change the wording for that!

Regarding the "do not show this again" button, I could add another option in the module settings to re-enable the popup, but you should still get a small yellow warning banner in Foundry whenever the module stops you from doing something, for example trying to load a crossbow that's already loaded:

Is that what you mean?

[mustangsami]

Hi Jonathan, No worries. Was very glad to see a better way to handle reloading was available. Re the warning module, oh ok great! I was too afraid to click don't show again to see that it happens, so that's ideal! Thanks for letting me know. I'll keep an eye out for any other potential improvement in the module. Thanks again. Sami

…

On Tue, 8 Nov 2022, 08:11 Jonathan Calvert, ***@***.***> wrote: Hi there, thanks for your appreciation and feedback! I actually had never realised that I'd allowed that popup to appear for times when you weren't trying to fire a weapon, I'll have to change the wording for that! Regarding the "do not show this again" button, I could add another option in the module settings to re-enable the popup, but you should still get a small yellow warning banner in Foundry whenever the module stops you from doing something, for example trying to load a crossbow that's already loaded: [image: image] <https://user-images.githubusercontent.com/38069151/200509792-20c6b4fa-c15e-4994-b9ff-9b545db6b048.png> Is that what you mean? — Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4B6KPENT2FB5PDUQADFTPLWHIDMVANCNFSM6AAAAAARZYTZMM> . You are receiving this because you authored the thread.Message ID: <JDCalvert/FVTT-PF2e-Ranged-Combat/repo-discussions/91/comments/4084025@ github.com>