Fix: It will be possible to configure toolbar offset without overridi…

…ng preconfigured toolbar items. See ckeditor/ckeditor5#572.
JDinABox · Sep 30, 2017 · ebcc189 · ebcc189
1 parent fc12c58
commit ebcc189
Show file tree

Hide file tree

Showing 3 changed files with 73 additions and 22 deletions.
diff --git a/build-config.js b/build-config.js
@@ -38,17 +38,19 @@ module.exports = {
 
 	// Editor config.
 	config: {
-		toolbar: [
-			'headings',
-			'bold',
-			'italic',
-			'link',
-			'bulletedList',
-			'numberedList',
-			'blockQuote',
-			'undo',
-			'redo'
-		],
+		toolbar: {
+			items: [
+				'headings',
+				'bold',
+				'italic',
+				'link',
+				'bulletedList',
+				'numberedList',
+				'blockQuote',
+				'undo',
+				'redo'
+			]
+		},
 
 		image: {
 			toolbar: [ 'imageStyleFull', 'imageStyleSide', '|', 'imageTextAlternative' ]

diff --git a/src/ckeditor.js b/src/ckeditor.js
@@ -43,17 +43,19 @@ ClassicEditor.build = {
 		ImageuploadPlugin
 	],
 	config: {
-		toolbar: [
-			'headings',
-			'bold',
-			'italic',
-			'link',
-			'bulletedList',
-			'numberedList',
-			'blockQuote',
-			'undo',
-			'redo'
-		],
+		toolbar: {
+			items: [
+				'headings',
+				'bold',
+				'italic',
+				'link',
+				'bulletedList',
+				'numberedList',
+				'blockQuote',
+				'undo',
+				'redo'
+			]
+		},
 		image: {
 			toolbar: [
 				'imageStyleFull',

diff --git a/tests/ckeditor.js b/tests/ckeditor.js
@@ -20,6 +20,7 @@ describe( 'ClassicEditor build', () => {
 
 	afterEach( () => {
 		editorElement.remove();
+		editor = null;
 	} );
 
 	describe( 'buid', () => {
@@ -82,6 +83,17 @@ describe( 'ClassicEditor build', () => {
 	} );
 
 	describe( 'plugins', () => {
+		beforeEach( () => {
+			return ClassicEditor.create( editorElement )
+				.then( newEditor => {
+					editor = newEditor;
+				} );
+		} );
+
+		afterEach( () => {
+			return editor.destroy();
+		} );
+
 		it( 'paragraph works', () => {
 			const data = '<p>Some text inside a paragraph.</p>';
 
@@ -153,4 +165,39 @@ describe( 'ClassicEditor build', () => {
 			expect( editor.getData() ).to.equal( data );
 		} );
 	} );
+
+	describe( 'config', () => {
+		afterEach( () => {
+			return editor.destroy();
+		} );
+
+		// https://github.com/ckeditor/ckeditor5/issues/572
+		it( 'allows configure toolbar items through config.toolbar', () => {
+			return ClassicEditor
+				.create( editorElement, {
+					toolbar: [ 'bold' ]
+				} )
+				.then( newEditor => {
+					editor = newEditor;
+
+					expect( editor.ui.view.toolbar.items.length ).to.equal( 1 );
+				} );
+		} );
+
+		// https://github.com/ckeditor/ckeditor5/issues/572
+		it( 'allows configure toolbar offset without overriding toolbar items', () => {
+			return ClassicEditor
+				.create( editorElement, {
+					toolbar: {
+						viewportTopOffset: 42
+					}
+				} )
+				.then( newEditor => {
+					editor = newEditor;
+
+					expect( editor.ui.view.toolbar.items.length ).to.equal( 9 );
+					expect( editor.ui.view.stickyPanel.viewportTopOffset ).to.equal( 42 );
+				} );
+		} );
+	} );
 } );