Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Highline Ruby 3.3 and reline compatible #266

Closed
abinoam opened this issue Dec 30, 2023 · 1 comment
Closed

Make Highline Ruby 3.3 and reline compatible #266

abinoam opened this issue Dec 30, 2023 · 1 comment
Assignees

Comments

@abinoam
Copy link
Collaborator

abinoam commented Dec 30, 2023

With the release of Ruby 3.3, the ext/readline library has been deprecated in favor of reline, a Ruby-based implementation of readline.

This represents a significant milestone for HighLine, akin to the impact of the introduction of io/console. HighLine, being an established Ruby library, originally emerged at a time when tools facilitating console interaction and cross-platform compatibility were limited. HighLine addressed these challenges using a series of conditional (if/else) statements and workarounds.

The advent of io/console alleviated some of these complexities. Now, with reline, we anticipate further simplification and efficiency in handling console interactions.

This issue aims to initiate the process of transitioning HighLine's codebase to utilize reline. A key objective is to ensure HighLine remains compatible with other Ruby implementations, particularly JRuby.

For more details on the Ruby 3.3 release, please refer to: Ruby 3.3.0 Release Notes.

cc: @JEG2, @ayacabta, @nobu, @hsbt, @headius

@abinoam
Copy link
Collaborator Author

abinoam commented Jan 5, 2024

Solved #265

@abinoam abinoam closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant