Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abbrev gem as dependency #264

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Add abbrev gem as dependency #264

merged 1 commit into from
Dec 30, 2023

Conversation

mathieujobin
Copy link
Contributor

abbrev has been bundled as a gem, and will be removed from the stdlib from ruby 3.4.0

under 3.3.0, this will remove this warning

warning: abbrev was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add abbrev to your Gemfile or gemspec. Also contact author of highline-2.1.0 to add abbrev into its gemspec.

abbrev has been bundled as a gem, and will be removed from the stdlib from ruby 3.4.0

under 3.3.0, this will remove this warning

> warning: abbrev was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add abbrev to your Gemfile or gemspec. Also contact author of highline-2.1.0 to add abbrev into its gemspec.
@abinoam
Copy link
Collaborator

abinoam commented Dec 30, 2023

Hi @mathieujobin

Thank you very much for your contribution!

PS: The failing test is because of the deprecation of ext/readline and I'll try to fix it in #265 #266

@abinoam abinoam merged commit 972222b into JEG2:master Dec 30, 2023
14 of 16 checks passed
@mathieujobin mathieujobin deleted the patch-1 branch January 3, 2024 00:25
@abinoam abinoam mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants