fix : update review image #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berygna
approved these changes
Sep 19, 2024
# Conflicts: # src/main/java/jjhhyb/deepvalley/community/service/ReviewImageService.java # src/test/java/jjhhyb/deepvalley/community/ReviewServiceTest.java
hanni66
added a commit
that referenced
this pull request
Nov 12, 2024
* feat: Add Suggest API (#119) * feat: Add default thumbnail to valley (#121) * feat: Add sorting to valley search (#123) * Member name ์ถ๊ฐ ๋ฐ ๊ณต๊ฐ ๋ถ๋ถ ์์ (#124) * feat : ReviewServiceTest ์ฝ๋ ์์ฑ * feat : ReviewDetailResponse์ ์ ์ ์ ํ๋กํurl ์ถ๊ฐ ๋ฐ Null ์ฒดํฌ * fix : ReviewDetailResponse ๋ถ๋ถ ์์ * fix : ๊ธฐ์กด ๋ฆฌ๋ทฐ ์ด๋ฏธ์ง์์ ์ ๋ฐ์ดํธ๋ฅผ ํตํด ๋ฆฌ๋ทฐ ์ด๋ฏธ์ง๊ฐ ์ญ์ ๋๋ ๊ฒฝ์ฐ ์ถ๊ฐ * feat : ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ์ค์ผ๋ก ์ถ์ฒ ๊ณ๊ณก api ์ถ๊ฐ * feat : ์ถ์ฒ ๊ณ๊ณก api ํ ์คํธ ์ฝ๋ ์ถ๊ฐ * feat : 10๊ฐ์์ 5๊ฐ๋ก ์์ * fix : deleteByMember ์ถ๊ฐ * fix : response ๋ถ๋ถ ์์ (์ ์ฒด Tag ๋ณด๋ด๊ธฐ) * fix : ๊ณ๊ณก ์ฌ์ง ์กฐํ ๋ถ๋ถ ์์ * fix : ๊ณ๊ณก ์ฌ์ง ์กฐํ response ์์ * fix : member -> set login date, review -> update memberId, placeId * feat : place ์ ์ ๋ฐ์ดํธ ๋๋ ๋ถ๋ถ ์์ * feat : member name ์ถ๊ฐ ๋ฐ ๊ณต๊ฐ/๋น๊ณต๊ฐ ๋ถ๋ถ ์์ * feat : ๋ฆฌ๋ทฐ ๊ณต๊ฐ ๋ฒ์์ ๋ฐ๋ผ ํํฐ๋ง * Fix : ๋ฆฌ๋ทฐ ์ ๋ฐ์ดํธ ์ฌ์ง ์ ๋ก๋ ๋ถ๋ถ ๋ก์ง ์์ (#125) * feat : ReviewServiceTest ์ฝ๋ ์์ฑ * feat : ReviewDetailResponse์ ์ ์ ์ ํ๋กํurl ์ถ๊ฐ ๋ฐ Null ์ฒดํฌ * fix : ReviewDetailResponse ๋ถ๋ถ ์์ * fix : ๊ธฐ์กด ๋ฆฌ๋ทฐ ์ด๋ฏธ์ง์์ ์ ๋ฐ์ดํธ๋ฅผ ํตํด ๋ฆฌ๋ทฐ ์ด๋ฏธ์ง๊ฐ ์ญ์ ๋๋ ๊ฒฝ์ฐ ์ถ๊ฐ * feat : ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ์ค์ผ๋ก ์ถ์ฒ ๊ณ๊ณก api ์ถ๊ฐ * feat : ์ถ์ฒ ๊ณ๊ณก api ํ ์คํธ ์ฝ๋ ์ถ๊ฐ * feat : 10๊ฐ์์ 5๊ฐ๋ก ์์ * fix : deleteByMember ์ถ๊ฐ * fix : response ๋ถ๋ถ ์์ (์ ์ฒด Tag ๋ณด๋ด๊ธฐ) * fix : ๊ณ๊ณก ์ฌ์ง ์กฐํ ๋ถ๋ถ ์์ * fix : ๊ณ๊ณก ์ฌ์ง ์กฐํ response ์์ * fix : member -> set login date, review -> update memberId, placeId * feat : place ์ ์ ๋ฐ์ดํธ ๋๋ ๋ถ๋ถ ์์ * feat : member name ์ถ๊ฐ ๋ฐ ๊ณต๊ฐ/๋น๊ณต๊ฐ ๋ถ๋ถ ์์ * feat : ๋ฆฌ๋ทฐ ๊ณต๊ฐ ๋ฒ์์ ๋ฐ๋ผ ํํฐ๋ง * fix : ๋ฆฌ๋ทฐ ์์ ํ๊ธฐ ์ฌ์ง ์ ๋ก๋ ๋ถ๋ถ ์์ * fix : update review image And add testcode (#126) * Fix/review : import ์์ (#127) * fix : update review image And add testcode * Fix : import ์์ * Fix : import ์์ * Fix : updateReview * change : ReviewPostRequest * fix : update ์์ฑ ์ deleteimageurls ์ถ๊ฐ ํ add, delete ๊ตฌ๋ถ * fix : imageUrls ํ์ ์ค๋ฅ ์์ * fix : s3์์ ์ด๋ฏธ์ง ์ญ์ * fix : test์ฉ ์ฝ๋ * fix : update review * fix : update review * fix : updateReviewWithImages * fix : create review * fix : update review -> delete image --------- Co-authored-by: RALLY <berygna@gmail.com> Co-authored-by: hanni66 <72500673+hanni66@users.noreply.github.com> Co-authored-by: hanni66 <haeunkim0807@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Summary
๋ฆฌ๋ทฐ ์ด๋ฏธ์ง ์ ๋ฐ์ดํธ์ ์๊ธฐ๋ ์ค๋ฅ ์์ ๋ฐ ํ ์คํธ ์ฝ๋ ์ถ๊ฐ