vuln-fix: Temporary Directory Hijacking or Information Disclosure

This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure.

Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions
Severity: High
CVSSS: 7.3
Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: JLLeitschuh/security-research#10

Co-authored-by: Moderne <team@moderne.io>

src/test/java/org/jenkinsci/plugins/sma/SMAPackageTest.java

@@ -7,6 +7,7 @@
 import org.junit.Test;
 
 import java.io.File;
+import java.nio.file.Files;
 import java.util.Arrays;
 import java.util.List;
 
@@ -24,9 +25,7 @@ public class SMAPackageTest
     public void setUp() throws Exception
     {
         //Setup the fake workspace and package manifest
-        testWorkspace = File.createTempFile("TestWorkspace", "");
-        testWorkspace.delete();
-        testWorkspace.mkdirs();
+        testWorkspace = Files.createTempDirectory("TestWorkspace").toFile();
         testWorkspacePath = testWorkspace.getPath();
 
         String emptyString = "";