Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Quote reporter output path" #75

Conversation

Tapchicoma
Copy link
Collaborator

This reverts commit a515788.

This commit leads that reported output created under following path:

<subproject-dir>/"/home/myuser/work/ktlint-gradle/samples/kotlin-gradle/build/reports/ktlint/ktlint-main.txt"

I've opened issue on ktlint side for better supporting spaces in output path: pinterest/ktlint#177

@JLLeitschuh
Copy link
Owner

JLLeitschuh commented Mar 20, 2018

@Tapchicoma Can you open an issue with Ktlint and link to it here? In the meantime. This looks good.

Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eskatos Just letting you know that you fix is being reverted.

@Tapchicoma Tapchicoma merged commit df6427e into JLLeitschuh:master Mar 20, 2018
@Tapchicoma Tapchicoma deleted the revert-fix-for-output-dir-with-spaces branch March 20, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants