Fix additionalEditorconfig property not being accounted for up-to-date checks and caching #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e checks and caching Fixes JLLeitschuh#750
m-burst
commented
Apr 2, 2024
| @@ -147,6 +147,26 @@ class EditorConfigTests : AbstractPluginTest() { | |||
| } | |||
| } | |||
|
|
|||
| @DisplayName("Check task should rerun if additionalEditorconfig property changes") | |||
| @CommonTest | |||
| fun checkRerunOnAdditionalEditorconfigPropertyChange(gradleVersion: GradleVersion) { | |||
There was a problem hiding this comment.
I made sure that the test fails if val additionalEditorconfig is @Internal before changing it to @Input
|
You will need to update the changelog to pass checks as well |
|
Updated the changelog |
JLLeitschuh
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750