msgq: dont clean up uninitialized sockerts

JMPZ11 · Nov 15, 2019 · 4e513a8 · 4e513a8
1 parent c008b63
commit 4e513a8
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 6 deletions.
diff --git a/messaging/impl_msgq.cc b/messaging/impl_msgq.cc
@@ -119,8 +119,10 @@ void MSGQSubSocket::setTimeout(int t){
 }
 
 MSGQSubSocket::~MSGQSubSocket(){
-  msgq_close_queue(q);
-  delete q;
+  if (q != NULL){
+    msgq_close_queue(q);
+    delete q;
+  }
 }
 
 void MSGQPubSocket::connect(Context *context, std::string endpoint){
@@ -150,8 +152,10 @@ int MSGQPubSocket::send(char *data, size_t size){
 }
 
 MSGQPubSocket::~MSGQPubSocket(){
-  msgq_close_queue(q);
-  delete q;
+  if (q != NULL){
+    msgq_close_queue(q);
+    delete q;
+  }
 }
 
 

diff --git a/messaging/impl_msgq.hpp b/messaging/impl_msgq.hpp
@@ -31,7 +31,7 @@ class MSGQMessage : public Message {
 
 class MSGQSubSocket : public SubSocket {
 private:
-  msgq_queue_t * q;
+  msgq_queue_t * q = NULL;
   int timeout;
 public:
   void connect(Context *context, std::string endpoint, std::string address, bool conflate=false);
@@ -43,7 +43,7 @@ class MSGQSubSocket : public SubSocket {
 
 class MSGQPubSocket : public PubSocket {
 private:
-  msgq_queue_t * q;
+  msgq_queue_t * q = NULL;
 public:
   void connect(Context *context, std::string endpoint);
   int sendMessage(Message *message);

diff --git a/messaging/stress.py b/messaging/stress.py
@@ -0,0 +1,19 @@
+import time
+from messaging_pyx import Context, Poller, SubSocket, PubSocket # pylint: disable=no-name-in-module, import-error
+
+#21845
+#32767 after closing mmap fd
+
+if __name__ == "__main__":
+  c = Context()
+  pub_sock = PubSocket()
+  pub_sock.connect(c, "controlsState")
+
+  for i in range(int(1e10)):
+    print(i)
+    sub_sock = SubSocket()
+    sub_sock.connect(c, "controlsState")
+
+
+    pub_sock.send(b'a')
+    print(sub_sock.receive())