Refactor/de-duplicate view XML and add a CDU close-up view #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I was half-asleep when I originally made this PR.)
This PR adds a dedicated view option for the CDUs. I tried setting the view to the next unused number (105) but the view would not show up in FlightGear as an option unless I picked a different number. Additionally, I added this to common.xml as it wasn't immediately clear if it was necessary to also add it to common-IAE.xml (not sure what that is). If I need to add it in both places I can do that, or perhaps it would be better to add something like aviews.xml
file to contain the common views so there isn't as much duplication of code.This PR adds the following:
common.xml
and once incommon-IAE.xml
. This PR moves these definitions into a newcommon-views.xml
file. This provides the same functionality as before while de-duplicating the code, reducing complexity and improving organization.common-views.xml
, a close-up view of the CDU (all variants have the CDU, so it is 'common'). It also gives a good view of the radar beside it. The new view looks like this (note this screenshot is taken on an ultra-wide monitor, so it will vary slightly):