Skip to content

Commit

Permalink
test/#359: UpdateMember Controller 테스트
Browse files Browse the repository at this point in the history
  • Loading branch information
@LJH098
LJH098 committed Jul 8, 2024
1 parent 9a32755 commit 7a56cdd
Show file tree
Hide file tree
Showing 2 changed files with 242 additions and 1 deletion.
2 changes: 1 addition & 1 deletion BE/exceed/src/test/java/com/gaebaljip/exceed/member/UpdateMemberIntegrationTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void when_updateMember_expected_success() throws Exception {
@Test
@WithMockUser(memberId = 1000L)
@DisplayName("회원 수정 실패 - 회원이 존재하지 않음")
void when_updateMember_InvalidMember_expected_exception() throws Exception {
void when_updateMember_member_invalid_expected_exception() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
Expand Down
241 changes: 241 additions & 0 deletions BE/exceed/src/test/java/com/gaebaljip/exceed/member/adapter/UpdateMemberControllerTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,241 @@
package com.gaebaljip.exceed.member.adapter;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.ResultActions;

import com.gaebaljip.exceed.common.ControllerTest;
import com.gaebaljip.exceed.common.ValidationMessage;
import com.gaebaljip.exceed.common.WithMockUser;
import com.gaebaljip.exceed.dto.request.UpdateMemberRequest;
import com.gaebaljip.exceed.member.adapter.in.UpdateMemberController;
import com.gaebaljip.exceed.member.application.port.in.UpdateMemberUsecase;

@WebMvcTest(UpdateMemberController.class)
public class UpdateMemberControllerTest extends ControllerTest {
@MockBean private UpdateMemberUsecase updateMemberUsecase;

@Test
@DisplayName("회원 수정 성공")
@WithMockUser
void when_updateMember_expected_success() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(180.3)
.activity("VERY_ACTIVE")
.age(40)
.gender("MALE")
.etc("회원 수정")
.build();
// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpect(status().isOk());
}

@Test
@DisplayName("회원 수정 실패 - 키를 입력하지 않은 경우")
@WithMockUser
void when_updateMember_height_null_expected_exception() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(null)
.activity("VERY_ACTIVE")
.age(40)
.gender("MALE")
.etc("회원 수정")
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value("키를 " + ValidationMessage.NOT_NULL));
}

@Test
@DisplayName("회원 수정 실패 - 키가 0보다 작은 경우")
@WithMockUser
void when_updateMember_height_negative_expected_exception() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(-1.0)
.activity("VERY_ACTIVE")
.age(40)
.gender("MALE")
.etc("회원 수정")
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value("키는 " + ValidationMessage.MIN_0));
}

@Test
@DisplayName("회원 수정 실패 - 나이를 입력하지 않은 경우")
@WithMockUser
void when_updateMember_age_null_expected_exception() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(180.3)
.activity("VERY_ACTIVE")
.age(null)
.gender("MALE")
.etc("회원 수정")
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value("나이를 " + ValidationMessage.NOT_NULL));
}

@Test
@DisplayName("회원 수정 실패 - 나이가 0보다 작은 경우")
@WithMockUser
void when_updateMember_age_negative_expected_exception() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(180.3)
.activity("VERY_ACTIVE")
.age(-1)
.gender("MALE")
.etc("회원 수정")
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value("나이는 " + ValidationMessage.MIN_0));
}

@Test
@DisplayName("회원 수정 실패 - 성별이 올바르지 않은 경우")
@WithMockUser
void when_updateMember_gender_invalid_expected_exception() throws Exception {
// given
String gender = "MALLY";

UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(180.3)
.activity("VERY_ACTIVE")
.age(40)
.gender(gender)
.etc("회원 수정")
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value(gender + "는 올바르지 않은 값입니다."));
}

@Test
@DisplayName("회원 수정 실패 - 활동량이 올바르지 않은 경우")
@WithMockUser
void when_updateMember_activity_invalid_expected_exception() throws Exception {
// given
String activity = "INVALID";

UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(180.3)
.activity(activity)
.age(40)
.gender("MALE")
.etc("회원 수정")
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value(activity + "는 올바르지 않은 값입니다."));
}

@Test
@DisplayName("회원 수정 실패 - 기타사항을 입력하지 않은 경우")
@WithMockUser
void when_updateMember_etc_null_expected_exception() throws Exception {
// given
UpdateMemberRequest updateMemberRequest =
UpdateMemberRequest.builder()
.height(180.3)
.activity("VERY_ACTIVE")
.age(40)
.gender("MALE")
.etc(null)
.build();

// when
ResultActions resultActions =
mockMvc.perform(
put("/v1/members")
.content(om.writeValueAsString(updateMemberRequest))
.contentType(MediaType.APPLICATION_JSON));

// then
resultActions.andExpectAll(
status().isBadRequest(),
jsonPath("$.error.reason").value("기타사항을 " + ValidationMessage.NOT_BLANK));
}
}

0 comments on commit 7a56cdd

Please sign in to comment.