[BE/FEAT] 회원수정 7일동안 안할 시 알림 보내기 기능 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangdaesun
approved these changes
Jun 7, 2024
Comment on lines
+34
to
+35
| sendEmitterUseCase.sendNotification( | ||
| emitter, eventId, eventId, "EventStream Created. [memberId=" + memberId + "]"); |
There was a problem hiding this comment.
3번째 파라미터 eventId -> emitterId로 수정해야할 것 같아요
There was a problem hiding this comment.
여기서 emitterId가 eventId랑 같기때문에 궅이 emitterId를 만들어서 넣을 필요는 없어 보여요
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class sendEmitterService implements SendEmitterUseCase { |
There was a problem hiding this comment.
"S"endEmitterService...
Comment on lines
75
to
76
| return Long.parseLong(eventId.split("_")[1]); | ||
| } |
There was a problem hiding this comment.
parseLong 메서드는 원시형으로 타입을 반환해서 Long 타입을 반환한다면 valueOf 메서드를 사용하는 것이 좋아보입니다.
|
|
||
| @UseCase | ||
| public interface ConnectEmitterUseCase { | ||
| SseEmitter connect(final String memberId, final String lastEventId); |
There was a problem hiding this comment.
인터페이스 이름에서 Connect한다는 거를 나타내고 있기도 하고 저희 메서드 네이밍 규칙에 맞추는 게 좋을 거 같은 데 어떻게 생각하시나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #294
📢 주요 변경사항