Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with noscript tag #134

Closed
da-yauhenzadziarkouski opened this issue Jun 25, 2021 · 5 comments
Closed

Problem with noscript tag #134

da-yauhenzadziarkouski opened this issue Jun 25, 2021 · 5 comments
Labels

Comments

@da-yauhenzadziarkouski
Copy link

da-yauhenzadziarkouski commented Jun 25, 2021

The problem:
It's a bit odd, but class names aren't replaced when the html code is wrapped in noscript tag <noscript>...</noscript>.

Example output:

<p class="nh nb nl">Some text goes here</p>

<noscript><p class="text-h2 text-gray-800 font-heading">Some text goes here</p></noscript>

Thank you @JPeer264 for the hard work on RCS, btw!

@JPeer264
Copy link
Owner

Could have waited with the release from the other ticket. But it is available with v3.6.3

@da-yauhenzadziarkouski
Copy link
Author

Thanks a lot @JPeer264 for the blazing-fast updates!

Somehow, version 3.6.3 throws an error in my setup:

[build:eleventy] Writing _site/index.html from ./src/index.njk.
[build:eleventy] Problem writing Eleventy templates: (more in DEBUG output)
[build:eleventy] > Expected corresponding JSX closing tag for <img>
[build:eleventy] 
[build:eleventy] `SyntaxError` was thrown:
[build:eleventy]     SyntaxError: Expected corresponding JSX closing tag for <img>
[build:eleventy]         at Espree.raise (/Users/yauhen/projects/eleventy/node_modules/espree/lib/espree.js:190:25)
[build:eleventy]         at Espree.jsx_parseElementAt (/Users/yauhen/projects/eleventy/node_modules/acorn-jsx/index.js:407:16)
[build:eleventy]         at Espree.jsx_parseElementAt (/Users/yauhen/projects/eleventy/node_modules/acorn-jsx/index.js:391:32)
[build:eleventy]         at Espree.jsx_parseElementAt (/Users/yauhen/projects/eleventy/node_modules/acorn-jsx/index.js:391:32)
[build:eleventy]         at Espree.jsx_parseElementAt (/Users/yauhen/projects/eleventy/node_modules/acorn-jsx/index.js:391:32)
[build:eleventy]         at Espree.jsx_parseElement (/Users/yauhen/projects/eleventy/node_modules/acorn-jsx/index.js:436:19)
[build:eleventy]         at Espree.parseExprAtom (/Users/yauhen/projects/eleventy/node_modules/acorn-jsx/index.js:443:21)
[build:eleventy]         at Espree.pp$3.parseExprSubscripts (/Users/yauhen/projects/eleventy/node_modules/acorn/dist/acorn.js:2129:21)
[build:eleventy]         at Espree.pp$3.parseMaybeUnary (/Users/yauhen/projects/eleventy/node_modules/acorn/dist/acorn.js:2106:19)
[build:eleventy]         at Espree.pp$3.parseExprOps (/Users/yauhen/projects/eleventy/node_modules/acorn/dist/acorn.js:2041:21)
[build:eleventy] Copied 10 files / Wrote 2 files in 1.36 seconds (v0.12.1)
[build:eleventy] npm ERR! code ELIFECYCLE
[build:eleventy] npm ERR! errno 1
[build:eleventy] npm ERR! eleventy@ build:eleventy: `eleventy`
[build:eleventy] npm ERR! Exit status 1
[build:eleventy] npm ERR! 
[build:eleventy] npm ERR! Failed at the eleventy@ build:eleventy script.
[build:eleventy] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I've tried to dig in the RCS code with no luck :)
Version 3.6.2 works perfectly, btw.

Thanks again!

@JPeer264
Copy link
Owner

JPeer264 commented Jun 25, 2021

Where do you have that img tag? Is it inside the <noscript> attribute?

I'm sorry. I was too fast in fixing that one. This one is now fixed for sure in v3.6.4

@da-yauhenzadziarkouski
Copy link
Author

Wow! Thanks a ton, sir! 3.6.4 works like a charm! Have a great weekend :)

@JPeer264
Copy link
Owner

Thanks you too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants