-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add basic cli #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with the suggested changes and an update to the build file, we'd be ready.
…ommand line in README.
Hi, makes sense. I think it's better not to have two bin options so went with the original package name, but happy to make further improvements. Thanks! |
I'm thinking maybe we should add a |
Oh you're right, I just added the package name as a bin mapping. |
I changed to avoid a dist file (I think CLI users can generally use the latest version) and linted the file. If you want to take a look, I think it should be ready after that. |
Makes sense. For completeness (…) I added a |
Oh! I wasn't aware of that approach, reverted now. |
So do the changes I added look ok? |
Yes, it all "lgtm." Thanks! |
Thanks for the PR! Released as part of v8.1.0 |
Thanks for guiding me through it. |
PR description
Adds a basic command line interface. No tests are provided since it just invokes the tested lib and we aren't here to test the runtime.
Checklist
npm test
, ensuring linting passes