Remove unnecessary parenthesis in ON clause of MERGE statement #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wumpz
reviewed
Jul 26, 2020
|
Not sure I understand the question. AFAICS an expression can have parenthesis around for "grouping" purposes anyway, so removing the explicit parenthesis should be fine. |
|
That's what I ment. At the moment I am not able to merge. Give me some time. |
|
Did you check your changes? I had many failing tests after merging it. So for now I reverted it. |
|
I did not check the tests. I thought that this was an easy fix because optional parenthesis are already defined by the expression rule, but if this is more involved, I guess it's not worth pursuing this further, especially since Oracle mandates the same syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.