COMMENT ON VIEW #1024
Merged
COMMENT ON VIEW #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* testcase "testCommentOnView" JSQLParser#1023
AnEmortalKid
approved these changes
Jul 26, 2020
|
@AnEmortalKid |
gitmotte
added a commit
to gitmotte/JSqlParser
that referenced
this pull request
Sep 16, 2020
wumpz
pushed a commit
that referenced
this pull request
Nov 6, 2020
* * add with prefix for fluent setters. #1004 * add getters * * add with prefix for fluent setters. (revert to chaining setters, do not break current api) #1004 * * add with prefix for fluent setters. (revert to chaining setters, do not break current api) #1004 * use new methods within testcases * use new methods within testcases * use new methods within testcases * use new methods within testcases * use new methods within testcases * use new methods within testcases * use new methods within testcases * use new methods within testcases * remove create() methods - they do not add enough value to be justified * * use new methods within testcases * add some constructors * fix and add "with" / "add" methods * * use new methods within testcases * * use new methods within testcases * add some constructors * * renamed constant * use new methods within testcases * use new methods within testcases * use new methods within testcases * use new methods within testcases * * use new methods within testcases * add some with-methods * add getter/setter named after the field without abbrivation * * use new methods within testcases * remove empty implicit constructor * return the deparsed Statement - object * compare object tree * compare object tree * * fix ObjectTreeToStringStyle * compare object tree * remove casts not needed * * use new methods within testcases * add some "set" "with" "add" methods missing * * use new methods within testcases * add empty constructors and override with-/add-methods returning concrete type * * add ReflectionModelTest * * use new methods within testcases * fix checkstyle errors * license header * remove test-classes from ReflectionModelTest * remove visitoradapter-classes from ReflectionModelTest * * add SelectDeParser(StringBuilder) * remove overriding setters/getters of buffer #1007 * push to synbee-contrib org.synbee.commons.contrib:jsqlparser:3.2-0.0.6-SNAPSHOT * add ValidationUtil for simple validation of one or more statements * remove overrides of * getCause * printStackTrace variants why add an additional cause ? set cause.getMessage() the message within constructor JSQLParserException(Throwable cause), othewise cause.toString() will be set as default. * add ValidationVisitor showcase #1005 * add ValidationUtil for simple validation of one or more statements * remove overrides of * getCause * printStackTrace variants why add an additional cause ? set cause.getMessage() the message within constructor JSQLParserException(Throwable cause), othewise cause.toString() will be set as default. * visit(ShowTablesStatement) * copyright/license * add stubs (use deparsers as template) * Merge branch 'master.validate' of https://github.com/gitmotte/JSqlParser.git into master.validate * add ValidationVisitor showcase #1005 * add ValidationUtil for simple validation of one or more statements * remove overrides of * getCause * printStackTrace variants why add an additional cause ? set cause.getMessage() the message within constructor JSQLParserException(Throwable cause), othewise cause.toString() will be set as default. * visit(ShowTablesStatement) * add stubs (use deparsers as template) * Merge branch 'master.validate' of https://github.com/gitmotte/JSqlParser.git into master.validate * add tests for ValidationUtil * + implements OrderByVisitor * split Expressionvalidator which implements both ItemsListVisitor and Expressionvisitor into Expressionvalidator and ItemListValidator * Merge branch 'github.validate' * implement upsertvalidator * add copyright * validate through given ValidationCapability's * * switch to new method forced by ValidationCapability.validate(ValidationContext context, Consumer<String> errorMessageConsumer); * add AllowedTypesValidation * add FeatureConfiguration * use FeatureConfiguration within parser * repair pom.xml * repair pom.xml * repair pom.xml * repair pom.xml * * make FeatureConfiguration not a singleton any more * CCJSqlParser extends AbstractJSqlParser<CCJSqlParser> * add FeaturesAllowed for testing against features allowed * implement some Validators * basic implementation of DatabaseMetaDataValidation / JdbcDatabaseMetaDataCapability * moving classes to sub-packages * * moving classes to sub-packages * fixing some bugs * repair pom.xml * add and fix validations * add javadoc * * force definition of ```public String getMessage(Feature feature)``` in FeatureSetValidation * allow all objects as feature-value - this may be needed by the parser, if a none-boolean configuration is needed * impl. * SelectValidator.visit(PlainSelect) * OrderByValidator * add Version-enums * impl. * InsertValidator * multiple implementations of visit(SubSelect) -> forward to SelectValidator * add some known features to SqlServerVersion * refactoring enum-name should be upper case * add ansi sql enum * refactoring enum-name should be upper case * implement limitvalidator * + validateOffset * + validateFetch * + validate Pivot, UnPivot, PivotXml * + implement DropValidator * change testcase to image a more probably usecase * * add javadoc and * predefined sets for EXECUTE, ALTER, DROP * allow to combine FeatureSets * * implement executevalidator * implement ExpressionValidator * implement GrantValidator * javadoc and complete SELECT constant * use utility methods from AbstractValidator * more user friendly names * javadoc * add subtypes for ValidationException * ValidationParseException * DatabaseException * UnexpectedValidationException and change Set<String> errors to Set<ValidationException> for collect. * javadoc & rename exception * rename method * extract parsing task into package - private class for {@link ValidationUtil} to parse the statements * within it's own {@link ValidationCapability} * add null-check for parsedStatement * bugfix - do not collect duplicates * implement toString() for * ValidationError * ValidationException * add simple caching * + validateOptionalFromItem(s) * * implement GroupByValidator * implement merge-validator * renaming ItemListValidator -> ItemsListValidator * + validateOptionalItemsList + implement ReplaceValidator + use validateOptionalColumns, validateOptionalExpression where possible * * remove validateOptionalColumns -> switch to validateOptionalExpressions * move validateOptionalOrderByElements to AbstractValidator * add validateOptional in AbstractValidator * add validateOptionalList in AbstractValidator * + SetStatementValidator * + ValuesStatementValidator * + UseStatementValidator * * implement UpdateValidator * * implement ShowStatementValidator/ShowColumnsStatementValidator * * implement UpdateValidator * * add Feature.jdbcParameter, Feature.jdbcNamedParameter, to all featuresets * + Version.getFeaturesClone * add javadoc to Version-enum-constructors * + validateOptionalFeature * * implement DeleteValidator * ... * fix typo * small optimization * * move method getFeaturesClone to FeatureSet * implement join - validation * add copy(), add(Collection), remove(*) methods to FeaturesAllowed * * add join - features to sqlserver, h2 * implementations * bugfix - merging the errors * copyright * #1022 * add more fine granular control for setOperations * fix nullpointerexception * add more fine granular control for comments * add Features supported * * add javadoc * add features to *Version-files * extract methods isNotEmpty * check for isNotEmpty * * add features to *Version-files * always parse net.sf.jsqlparser.statement.Statements and validate the list of included net.sf.jsqlparser.statement.Statement's * add known mariadb features * new names-set for FeaturesAllowed * new names-set for FeaturesAllowed * new names-set for FeaturesAllowed * add ature.withItem, Feature.withItemRecursive to H2 * Feature.setOperation, Feature.setOperationUnion, Feature.setOperationIntersect, Feature.setOperationExcept, for MariaDb * add features to SQLServer * Merge branch 'master.orig' into github.validate * @OverRide() -> @OverRide * fix typing error "joinStaight" > joinStraight * rename Feature "insertValues" -> "values" and use "insertValues" for INSERT INTO ... VALUES * add javadoc * add Feature.selectGroupByGroupingSets to PostgresqlVersion * implement basic OracleVersion * add Feature.mySql* - also supported by mariadb * add some more finegraned control over "drop" Feature. * drop, * dropTable, * dropIndex, * dropView, * dropSchema, * dropSequence, * dropIfExists, * complete FeaturesAllowed groups INSERT/UPDATE/DELETE/MERGE/DML * add link to documentation * fix - duplicate use of feature "function" - the use of functions in statements and "createFunction" as a ddl statement * TODO this feature seams very close to a jsqlparser-user usecase * * implement MySqlVersion * replace feature Feature.dropIfExists by features dropTableIfExists, dropIndexIfExists, dropViewIfExists, dropSchemaIfExists, dropSequenceIfExists * add methods FeatureSet.getNotContained FeatureSet.retainAll * remove HSQLDBVersion - do not support this variant * remove HSQLDBVersion - do not support this variant * add unit-test * + add unittests for * UpdateValidator * DeleteValidator add stubs for all other Validator-classes + ModifyableFeatureSet * add some utility-methods in ValidationTestAsserts * complete unit-tests for InsertValidator * remote Feature.insertReturningExpressionList for Oracle - returning_clause requires INTO clause (only PL/SQL) * add some more select validation tests * add DropValidatorTests * add DropValidatorTests * add CreateTableValidatorTests * add CreateTableValidatorTests * add ExpressionValidatorTests * add OrderByValidatorTest * use isNotEmpty * implement GroupByValidatorTest * implement CreateSequenceValidatorTest * remove @ignore - test is ok * implement CreateIndexValidatorTest * implement CreateViewValidatorTest * enable validation of Feature.commentOnView (#1024 is merged already) * change format of #toString() for better readability * * implement MergeValidatorTest * implement ReplaceValidatorTest * implement StatementValidatorTest * rename * ValidationUtil -> Validation * ValidatorUtil -> ValidationUtil add testcases for ValidationUtil * add DatabaseMetaDataValidationTest * checkstyle fix * add copyright statement * add unit-tests for show tables, show column, show statements * * add ExecuteValidatorTest * as there is a difference between execute <procedure> and execute [immediate] <dynamic sql> with USING expr, ... remove support for execute on MYSQL, MARIADB, ORACLE * * add ExecuteValidatorTest for CALL fnName (mysql, mariadb, postgres) * add upsertvalidatortest * add GrantValidatorTest * add AlterSequenceValidatorTest * add AlterSequenceValidatorTest * add AlterViewValidatorTest * add AlterValidatorTest * replace != null by isNotEmpty on collections * fix formatting * add validate commit * add validate block * add DeclareStatementValidatorTest * let NamesLookup implement UnaryOperator<String> * let NamesLookup implement UnaryOperator<String> * add javadoc * add more DatabaseMetaDataValidationTest's * extract JdbcDatabaseMetaDataCapability.splitAndValidateMinMax * add pivot/unpivot/pivotxml validation testcases * add testcase for Feature.tableFunction * add test for lateral joins and subjoins * add testValidationRowMovementOption * add values validator test * move tests to LimitValidatorTest * move tests to UseStatementValidatorTest * add tests for SET - statements * fix checkstyle error * new serialVersionUID * add validation for NamedObject not existing * need table/view reference to validate column names * fix typo * fix errormessage (Arrays.toString(types)) * add trigger, alias return null, instead of throwing exception, if not found * extract NamesLookup to own file (jdk-bug enum inner classes) * fix name-check AlterOperation.ALTER * fix error message * remove methods not needed (they only delegate to ValidationContext) * add tests - validate metadata * fix compile error * fix columnExists check - depending on the statement the prefix is an alias, a table/view or it has no prefix (need to lookup within all related tables/views) * fix javadoc warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMMENT ON VIEW #1023