Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compound statement tests #1545

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

rathboma
Copy link
Contributor

Hey!

I didn't see any tests for anonymous statement blocks so figured I'd add them!

So I added three new tests for compound statements / anonymous blocks

Note in the SQL files it says that the tests failed...but mvn test doesn't seem to show that at all? Not sure what I'm doing wrong, but wanted to make a PR anyway to see if the failures are legit?

@manticore-projects
Copy link
Contributor

Greetings!

First of all, thanks a lot for interest and contributing. Well appreciated.

On the details, we may need a few changes:

  1. You have touched that "Special Oracle Tests" section, which is not advisable. This section is reserved for exotic Oracle features, and some of them are meant/known to fail -- and thus its silent.

  2. Instead move your Tests into the normal test section and use the standard assertCanBeParsedAndDeparsed method. Do not add new failing tests or missing features without a solution please.

  3. Your tests are BEGIN... END blocks and should be supported and working. What exactly is different about your examples please?

@manticore-projects
Copy link
Contributor

Please have a look at net/sf/jsqlparser/statement/BlockTest.java. There are Tests on Block Statements already and your additional Tests could go there.

@rathboma
Copy link
Contributor Author

Ok, great! I'll add them there. I didn't see the block tests, so thought this might be a real contribution. I'll move them to that file this week (hopefully with a fix)

Matthew

@wumpz wumpz merged commit c1c38fe into JSQLParser:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants